[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 125536: Remove unused variable warnings
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2015-12-29 12:11:37
Message-ID: 20151229121137.18086.40594 () mimi ! kde ! org
[Download RAW message or body]
--===============3311733160991776592==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125536/#review90276
-----------------------------------------------------------
ping?
- Albert Astals Cid
On oct. 5, 2015, 10:41 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125536/
> -----------------------------------------------------------
>
> (Updated oct. 5, 2015, 10:41 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> Remove unused zip mime
> In k7zip i've opted for commenting instead of reverting since these magic values \
> may be hard to get again if needed and whoever sees it may not realize it was part \
> of the history and git log it
>
> Diffs
> -----
>
> src/k7zip.cpp 64c6b52
> src/ktar.cpp 49a6791
>
> Diff: https://git.reviewboard.kde.org/r/125536/diff/
>
>
> Testing
> -------
>
> clang compiles without warnings
>
>
> Thanks,
>
> Albert Astals Cid
>
>
--===============3311733160991776592==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125536/">https://git.reviewboard.kde.org/r/125536/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ping?</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On octubre 5th, 2015, 10:41 p.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated oct. 5, 2015, 10:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove unused zip mime In k7zip i've opted for \
commenting instead of reverting since these magic values may be hard to get again if \
needed and whoever sees it may not realize it was part of the history and git log \
it</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">clang compiles without warnings</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/k7zip.cpp <span style="color: grey">(64c6b52)</span></li>
<li>src/ktar.cpp <span style="color: grey">(49a6791)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125536/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3311733160991776592==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic