[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126555: Remove unused variable in KConfigPrivate
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2015-12-29 10:53:22
Message-ID: 20151229105322.18086.45068 () mimi ! kde ! org
[Download RAW message or body]
--===============7593381331965776200==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126555/#review90274
-----------------------------------------------------------
Ship it!
Ship It!
- Albert Astals Cid
On des. 29, 2015, 5:20 a.m., Matthew Dawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126555/
> -----------------------------------------------------------
>
> (Updated des. 29, 2015, 5:20 a.m.)
>
>
> Review request for KDE Frameworks and Matthew Dawson.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> This seems to be left over from KDE 3.5 times, and isn't referenced anywhere
> in the code. Since its a private header, just remove.
>
> Found by Coverity, issue 1175531.
>
>
> Diffs
> -----
>
> src/core/kconfig_p.h b93c8167bbab1d0403493505a5639524b4737f3c
>
> Diff: https://git.reviewboard.kde.org/r/126555/diff/
>
>
> Testing
> -------
>
> Compiles, test run. Grepped source code for references, none found.
>
>
> Thanks,
>
> Matthew Dawson
>
>
--===============7593381331965776200==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126555/">https://git.reviewboard.kde.org/r/126555/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On desembre 29th, 2015, 5:20 a.m. UTC, Matthew Dawson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Matthew Dawson.</div>
<p style="color: grey;"><i>Updated des. 29, 2015, 5:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This seems to be left over from KDE 3.5 times, and isn't referenced \
anywhere in the code. Since its a private header, just remove.
Found by Coverity, issue 1175531.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles, test run. Grepped source code for \
references, none found.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/kconfig_p.h <span style="color: \
grey">(b93c8167bbab1d0403493505a5639524b4737f3c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126555/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7593381331965776200==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic