'Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing u'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-frameworks-devel
Subject: Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing u
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-12-27 20:51:19
Message-ID: 20151227205119.18086.90418 () mimi ! kde ! org
[Download RAW message or body]

--===============3658467577700830112==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159>
> > 
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback in case \
> no FDO notification service is available 
> David Edmundson wrote:
> Ah, I see. 
> We've changed the --passive meaning so that this is no longer opt-in.
> 
> (you did say that in the updated description, but I didn't parse it properly)
> 
> So in matrix form:
> 
> passive|notifications running|action
> -------|--------|-------
> Yes | Yes | Show SNI and notification
> Yes | No  | Show SNI and notification
> No  | Yes | Show SNI
> No  | No  | Dialog directly
> 
> ?
> 
> Kai Uwe Broulik wrote:
> The "passive" is still opt in but I shifted the meaning a bit.
> 
> Passive now means "don't bother the user" or "don't draw attention", ie. don't show \
> a notification or dialog whatsoever, only SNI. Sorry, I only wrote into the change \
> summary. 
> passive | notifications running | action
> Yes.... | Yes.................. | Show SNI
> Yes.... | No................... | Show SNI
> No..... | Yes.................. | Show SNI and Notification
> No..... | No................... | Show DrKonqi dialog directly

If we go with this, we can effectively just swap the drop the passive flag addition \
in frameworks and re-use the AutoRestart flag? and assume !AutoRestart == Passive

It's how you're describing the usage in your blog post.

(would involve Plasma using the existing autorestart rather than doing it's own \
thing, but I like the idea of that)

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
-----------------------------------------------------------

On Dec. 27, 2015, 4:11 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2015, 4:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This adds a new "--passive" option to DrKonqi where it will only show a \
> StatusNotifierItem rather than bringing up the crash dialog right away. 
> This can be useful for auto-restarting shell services (like plasmashell, krunner, \
> kded) to improve the perceived quality of the product. 
> On Windows RT, for example, the guidelines even explicitly say "rather just dump \
> the user on the home screen than telling him something went wrong, so he can just \
> quickly start the app again instead of being annoyed by an error message". On iOS \
> you also just get dropped on the home screen. Windows desktop shows a "Searching \
> for a solution" dialog which was *the* major annoyance when something crashed, \
> rather than the actual crash. 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -----
> 
> drkonqi/CMakeLists.txt eaeaad4 
> drkonqi/main.cpp 7cbaae7 
> drkonqi/statusnotifier.h PRE-CREATION 
> drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> -------
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black \
> screen inbetween, just the panel restarting. Afterwards I got a SNI which opened \
> DrKonqi when tapped. 
> The SNI disappears after 1 minute because if you didn't bother to look after it by \
> then, you probably forgot what you did to cause the crash anyway :) 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============3658467577700830112==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126515/">https://git.reviewboard.kde.org/r/126515/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 27th, 2015, 6:24 p.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159" \
style="color: black; font-weight: bold; text-decoration: \
underline;">drkonqi/main.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char* argv[])</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">159</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="c1">// and we&#39;re not told to be unobstrusive, open DrKonqi dialog instead \
of showing an SNI</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and \
-&gt; or surely?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">both in code and comments.</p></pre>  \
</blockquote>

 <p>On December 27th, 2015, 6:31 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
and is correct:</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">I never want to show the \
dialog or a notification when we're passive.</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">I want \
to show the DrKonqi dialog instead of the KPassivePopup fallback in case no FDO \
notification service is available</li> </ul></pre>
 </blockquote>

 <p>On December 27th, 2015, 6:48 p.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, I \
see.  We've changed the --passive meaning so that this is no longer opt-in.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">(you did say that in the updated description, but I \
didn't parse it properly)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">So in matrix form:</p> <table \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;"> <thead style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <tr style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"> <th style="padding: 0.2em \
1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: \
inherit;border-bottom: 1px solid #bbb;">passive</th> <th style="padding: 0.2em \
1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: \
inherit;border-bottom: 1px solid #bbb;">notifications running</th> <th \
style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: \
0;line-height: inherit;border-bottom: 1px solid #bbb;">action</th> </tr>
</thead>
<tbody style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <tr style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"> <td style="padding: 0.2em \
1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: \
inherit;border-bottom: 1px solid #bbb;">Yes</td> <td style="padding: 0.2em \
1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: \
inherit;border-bottom: 1px solid #bbb;">Yes</td> <td style="padding: 0.2em \
1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: \
inherit;border-bottom: 1px solid #bbb;">Show SNI and notification</td> </tr>
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <td style="padding: 0.2em 1em;text-rendering: \
inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid \
#bbb;">Yes</td> <td style="padding: 0.2em 1em;text-rendering: inherit;white-space: \
normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;">No</td> <td \
style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: \
0;line-height: inherit;border-bottom: 1px solid #bbb;">Show SNI and notification</td> \
</tr> <tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <td style="padding: 0.2em 1em;text-rendering: \
inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid \
#bbb;">No</td> <td style="padding: 0.2em 1em;text-rendering: inherit;white-space: \
normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;">Yes</td> <td \
style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: \
0;line-height: inherit;border-bottom: 1px solid #bbb;">Show SNI</td> </tr>
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <td style="padding: 0.2em 1em;text-rendering: \
inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid \
#bbb;">No</td> <td style="padding: 0.2em 1em;text-rendering: inherit;white-space: \
normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;">No</td> <td \
style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: \
0;line-height: inherit;border-bottom: 1px solid #bbb;">Dialog directly</td> </tr>
</tbody>
</table>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">?</p></pre>  </blockquote>

 <p>On December 27th, 2015, 6:55 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
"passive" is still opt in but I shifted the meaning a bit.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Passive now means "don't bother the user" or "don't draw attention", ie. \
don't show a notification or dialog whatsoever, only SNI. Sorry, I only wrote into \
the change summary.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">passive | notifications running | \
action Yes.... | Yes.................. | Show SNI
Yes.... | No................... | Show SNI
No..... | Yes.................. | Show SNI and Notification
No..... | No................... | Show DrKonqi dialog directly</p></pre>
 </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we go with this, we can effectively just swap the drop the passive flag \
addition in frameworks and re-use the AutoRestart flag? and assume !AutoRestart == \
Passive It's how you're describing the usage in your blog \
post. (would involve Plasma using the existing autorestart \
rather than doing it's own thing, but I like the idea of that)</pre>

<p>- David</p>

<br />
<p>On December 27th, 2015, 4:11 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma, KDE Usability, and Martin \
Gräßlin.</div> <div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Dec. 27, 2015, 4:11 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds a new "--passive" option to DrKonqi where it \
will only show a StatusNotifierItem rather than bringing up the crash dialog right \
away.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This can be useful for auto-restarting shell services \
(like plasmashell, krunner, kded) to improve the perceived quality of the \
product.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On Windows RT, for example, the guidelines even \
explicitly say "rather just dump the user on the home screen than telling him \
something went wrong, so he can just quickly start the app again instead of being \
annoyed by an error message". On iOS you also just get dropped on the home screen. \
Windows desktop shows a "Searching for a solution" dialog which was <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">the</em> major annoyance when something crashed, rather than the actual \
crash.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Video here: \
https://www.youtube.com/watch?v=t0ZLs-juYKc</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I crashed plasmashell, it restarted so fast that you \
didn't even have a black screen inbetween, just the panel restarting. Afterwards I \
got a SNI which opened DrKonqi when tapped.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The SNI disappears \
after 1 minute because if you didn't bother to look after it by then, you probably \
forgot what you did to cause the crash anyway :)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>drkonqi/CMakeLists.txt <span style="color: grey">(eaeaad4)</span></li>

 <li>drkonqi/main.cpp <span style="color: grey">(7cbaae7)</span></li>

 <li>drkonqi/statusnotifier.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>drkonqi/statusnotifier.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126515/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3658467577700830112==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 