'Re: Review Request 126505: Do not show a warning color before the user even started typing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126505: Do not show a warning color before the user even started typing
From:       "Elvis Angelaccio" <elvis.angelaccio () kdemail ! net>
Date:       2015-12-27 14:36:28
Message-ID: 20151227143628.32122.81991 () mimi ! kde ! org
[Download RAW message or body]

--===============1210351649243137295==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126505/
-----------------------------------------------------------

(Updated Dec. 27, 2015, 2:36 p.m.)

Review request for KDE Frameworks and Christoph Feck.

Changes
-------

A mismatch is now detected as soon as the verification is not a prefix of the \
password. Not only this is better from the usability point of view, but now the patch \
is also much simpler.

Repository: kwidgetsaddons

Description
-------

As discussed in RR 125619 and 126426, the password verification field (in a \
KNewPasswordWidget) should not be marked as "wrong" before the user even started \
typing the verification password.

My revised approach is the following:

* the first time, no "warning color" is displayed at all. The user types something as \
                password and then something else as verification password.
* If a match occurred (e.g. pwd = 1234 and verification = 1234), we "enable" the \
warning color. So if the user "breaks" the match (e.g. changing the value in one of \
                the two fields) the warning color will be displayed.
* Otherwise, if a mismatch occurred, we also enable the warning color and we show it \
immediately. A mismatch occurs when the password and the verification password have \
same length but different content (e.g. pwd = 1234 and verification = 1233).

Diffs (updated)
-----

  autotests/knewpasswordwidgettest.h 43845128adec01aced4353c9f7986b7977829a2a 
  autotests/knewpasswordwidgettest.cpp 297b88d5f18b9cd37f0d26d94e56f38870756f20 
  src/knewpasswordwidget.cpp a1b59454a2c2d7c09ac32acec52d3fffa73f77fc 

Diff: https://git.reviewboard.kde.org/r/126505/diff/

Testing
-------

Autotests assert what described above. Gif pictures would explain the patch better \
than 1000 words, but I suck at creating them :(

Thanks,

Elvis Angelaccio

--===============1210351649243137295==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126505/">https://git.reviewboard.kde.org/r/126505/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Elvis Angelaccio.</div>

<p style="color: grey;"><i>Updated Dec. 27, 2015, 2:36 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A mismatch is now detected as soon as the verification is not a prefix \
of the password. Not only this is better from the usability point of view, but now \
the patch is also much simpler.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As discussed in RR 125619 and 126426, the password \
verification field (in a KNewPasswordWidget) should not be marked as "wrong" before \
the user even started typing the verification password.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My \
revised approach is the following:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">the first time, no "warning color" is displayed at all. The user types \
something as password and then something else as verification password.</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">If a match occurred (e.g. pwd = 1234 and verification = 1234), we "enable" \
the warning color. So if the user "breaks" the match (e.g. changing the value in one \
of the two fields) the warning color will be displayed.</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Otherwise, if a mismatch occurred, we also enable the warning color and we \
show it immediately. A mismatch occurs when the password and the verification \
password have same length but different content (e.g. pwd = 1234 and verification = \
1233).</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Autotests assert what described above. Gif pictures \
would explain the patch better than 1000 words, but I suck at creating them \
:(</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/knewpasswordwidgettest.h <span style="color: \
grey">(43845128adec01aced4353c9f7986b7977829a2a)</span></li>

 <li>autotests/knewpasswordwidgettest.cpp <span style="color: \
grey">(297b88d5f18b9cd37f0d26d94e56f38870756f20)</span></li>

 <li>src/knewpasswordwidget.cpp <span style="color: \
grey">(a1b59454a2c2d7c09ac32acec52d3fffa73f77fc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126505/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1210351649243137295==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 