'Review Request 126523: Use a KMessageWidget in KNewPasswordDialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 126523: Use a KMessageWidget in KNewPasswordDialog
From:       "Elvis Angelaccio" <elvis.angelaccio () kdemail ! net>
Date:       2015-12-26 10:18:11
Message-ID: 20151226101811.29845.64087 () mimi ! kde ! org
[Download RAW message or body]

--===============8657140605044218401==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126523/
-----------------------------------------------------------

Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, and Christoph \
Feck.

Repository: kwidgetsaddons

Description
-------

Currently a KNewPasswordDialog makes use of a KTitleWidget to display messages to the \
user about the password status (e.g. "password too short", etc.). This looks out of \
place, and so does the associated icon (see screenshots in RR 125619: \
https://git.reviewboard.kde.org/r/125619/ )

This patch replaces the KTitleWidget with a KMessageWidget. I also "downgraded" some \
of the previous "error" red icons to a `KMessageWidget::Warning` type (the orange one \
in the screenshots), because those kind of messages may be displayed before the user \
even started typing something as password.

Diffs
-----

  src/knewpassworddialog.cpp 1d7ca33ac010a2a1d0971a152d0bef23f78c414d 
  src/knewpassworddialog.ui 2b492d2a2984296105959d366a1d5306c80af54f 

Diff: https://git.reviewboard.kde.org/r/126523/diff/

Testing
-------

The KMessageWidgets behaves exactly like the KTitleWidget before: initially is \
hidden, then is displayed as soon as the user interacts with the password fields.

File Attachments
----------------

pwd-dialog-1.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png
 pwd-dialog-2.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png
 pwd-dialog-3.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png

Thanks,

Elvis Angelaccio

--===============8657140605044218401==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126523/">https://git.reviewboard.kde.org/r/126523/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, and Christoph \
Feck.</div> <div>By Elvis Angelaccio.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently a KNewPasswordDialog makes use of a \
KTitleWidget to display messages to the user about the password status (e.g. \
"password too short", etc.). This looks out of place, and so does the associated icon \
(see screenshots in RR 125619: https://git.reviewboard.kde.org/r/125619/ )</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This patch replaces the KTitleWidget with a KMessageWidget. I also \
"downgraded" some of the previous "error" red icons to a <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">KMessageWidget::Warning</code> type (the orange one in the screenshots), \
because those kind of messages may be displayed before the user even started typing \
something as password.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The KMessageWidgets behaves exactly like the \
KTitleWidget before: initially is hidden, then is displayed as soon as the user \
interacts with the password fields.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/knewpassworddialog.cpp <span style="color: \
grey">(1d7ca33ac010a2a1d0971a152d0bef23f78c414d)</span></li>

 <li>src/knewpassworddialog.ui <span style="color: \
grey">(2b492d2a2984296105959d366a1d5306c80af54f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126523/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png">pwd-dialog-1.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png">pwd-dialog-2.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png">pwd-dialog-3.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8657140605044218401==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 