[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-12-24 13:23:10
Message-ID: 20151224132310.29845.5620 () mimi ! kde ! org
[Download RAW message or body]
--===============3489022567555428012==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126392/#review90060
-----------------------------------------------------------
src/lib/io/kbackup.cpp (line 86)
<https://git.reviewboard.kde.org/r/126392/#comment61707>
because a string is appended to the existing one, i suggest to use QLatin1String \
here (there is an overload taking QLatin1String as an argument)
src/lib/io/kprocess.cpp (line 241)
<https://git.reviewboard.kde.org/r/126392/#comment61708>
because a string is appended to the existing one, i suggest to use QLatin1String \
here (there is an overload taking QLatin1String as an argument)
- Nick Shaforostoff
On Dec. 24, 2015, 11:58 a.m., Andrey Cygankov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126392/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2015, 11:58 a.m.)
>
>
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Fix some Clazy warnings:
> - unneeded heap allocation with QString
> - midRef() non-usage
> - isEmpty() non-usage
>
>
> Diffs
> -----
>
> src/lib/io/kbackup.h ead2de5
> autotests/ktexttohtmltest.cpp 81c3fc0
> src/lib/io/kprocess.cpp 1df61c0
> src/lib/io/kmessage.cpp 305318c
> src/lib/io/kdirwatch.cpp 34b32b7
> src/lib/io/kdirwatch_p.h 4483961
> src/lib/io/kbackup.cpp ec8b8b2
> src/lib/io/kurlmimedata.cpp 4095ee1
> src/lib/kaboutdata.h 0dbd7a0
> src/lib/kaboutdata.cpp 5d9a55e
> src/lib/randomness/krandom.cpp 2eb80d2
> src/lib/text/kmacroexpander.cpp 0d05ffd
> src/lib/text/kstringhandler.cpp 826ddcb
> src/lib/text/ktexttohtml.cpp d58f5c0
> src/lib/util/kshell.cpp 11892ce
>
> Diff: https://git.reviewboard.kde.org/r/126392/diff/
>
>
> Testing
> -------
>
> Compiling without errors
>
>
> Thanks,
>
> Andrey Cygankov
>
>
--===============3489022567555428012==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126392/">https://git.reviewboard.kde.org/r/126392/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126392/diff/4/?file=425645#file425645line86" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/io/kbackup.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
rcsBackupFile(const QString &qFilename,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">86</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qBackupFilename</span> <span class="o">+=</span> <span \
class="n">QString</span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLatin1</span></span><span class="p">(</span><span \
class="s">",v"</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">86</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qBackupFilename</span> <span class="o">+=</span> <span \
class="n">QString<span class="hl">Literal</span></span><span class="p">(</span><span \
class="s">",v"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">because a string is \
appended to the existing one, i suggest to use QLatin1String here (there is an \
overload taking QLatin1String as an argument)</pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126392/diff/4/?file=425649#file425649line241" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/io/kprocess.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KProcess::setShellCommand(const QString &cmd)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">241</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span class="n">prog</span> <span \
class="o">+=</span> <span class="n">Q<span class="hl">Latin1</span>String</span><span \
class="p">(</span><span class="s">"</span><span class="se">\\</span><span \
class="s">cmd.exe"</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">241</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span class="n">prog</span> <span \
class="o">+=</span> <span class="n">QString<span \
class="hl">Literal</span></span><span class="p">(</span><span \
class="s">"</span><span class="se">\\</span><span \
class="s">cmd.exe"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">because a string is \
appended to the existing one, i suggest to use QLatin1String here (there is an \
overload taking QLatin1String as an argument)</pre> </div>
</div>
<br />
<p>- Nick Shaforostoff</p>
<br />
<p>On December 24th, 2015, 11:58 a.m. UTC, Andrey Cygankov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Andrey Cygankov.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2015, 11:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix some Clazy warnings:
- unneeded heap allocation with QString
- midRef() non-usage
- isEmpty() non-usage</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiling without errors</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/io/kbackup.h <span style="color: grey">(ead2de5)</span></li>
<li>autotests/ktexttohtmltest.cpp <span style="color: grey">(81c3fc0)</span></li>
<li>src/lib/io/kprocess.cpp <span style="color: grey">(1df61c0)</span></li>
<li>src/lib/io/kmessage.cpp <span style="color: grey">(305318c)</span></li>
<li>src/lib/io/kdirwatch.cpp <span style="color: grey">(34b32b7)</span></li>
<li>src/lib/io/kdirwatch_p.h <span style="color: grey">(4483961)</span></li>
<li>src/lib/io/kbackup.cpp <span style="color: grey">(ec8b8b2)</span></li>
<li>src/lib/io/kurlmimedata.cpp <span style="color: grey">(4095ee1)</span></li>
<li>src/lib/kaboutdata.h <span style="color: grey">(0dbd7a0)</span></li>
<li>src/lib/kaboutdata.cpp <span style="color: grey">(5d9a55e)</span></li>
<li>src/lib/randomness/krandom.cpp <span style="color: grey">(2eb80d2)</span></li>
<li>src/lib/text/kmacroexpander.cpp <span style="color: grey">(0d05ffd)</span></li>
<li>src/lib/text/kstringhandler.cpp <span style="color: grey">(826ddcb)</span></li>
<li>src/lib/text/ktexttohtml.cpp <span style="color: grey">(d58f5c0)</span></li>
<li>src/lib/util/kshell.cpp <span style="color: grey">(11892ce)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126392/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3489022567555428012==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic