[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter
From: Ivan Čukić <ivan.cukic () kde ! org>
Date: 2015-12-22 17:17:40
Message-ID: 20151222171740.32218.70710 () mimi ! kde ! org
[Download RAW message or body]
--===============0265423132539772866==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Dec. 22, 2015, 4:59 p.m., Ivan Čukić wrote:
> > The patch seems straight-forward.
> >
> > I can not find the reference that QRegularExpression is thread-safe (the most I \
> > see is 'all functions in this class are reentrant which is stated for QRegExp as \
> > well).
> > The QRegExp vs QRegularExpression situation is quite confusing, but the later \
> > should be preferred in Qt 5.x - it is faster if nothing else.
>
> David Edmundson wrote:
> you're right docs don't mention it, but see Alex's comment on \
> https://git.reviewboard.kde.org/r/126455/
It wasn't that I don't trust you on its thread safety. :)
Just meant to leave it as a note for future reference if they decide to remove the \
'inner mutex' during some code clean-up and optimization attempts.
- Ivan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126474/#review89939
-----------------------------------------------------------
On Dec. 22, 2015, 4:52 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126474/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 4:52 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> A static QRegExp was used but it is not thread safe. QRegularExpression
> seems to be.
>
> BUG: 352356
>
>
> Diffs
> -----
>
> src/urifilters/shorturi/kshorturifilter.cpp \
> 1af4768b7b5ab9d1f5af52f17170d466d854b9bb
> Diff: https://git.reviewboard.kde.org/r/126474/diff/
>
>
> Testing
> -------
>
> I ran the autotests which includes urifilter and I've run krunner which uses it \
> extensively.
>
> Thanks,
>
> David Edmundson
>
>
--===============0265423132539772866==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126474/">https://git.reviewboard.kde.org/r/126474/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 22nd, 2015, 4:59 p.m. UTC, <b>Ivan \
Čukić</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The patch seems straight-forward.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I can not find the reference that QRegularExpression is thread-safe (the \
most I see is 'all functions in this class are reentrant which is stated for QRegExp \
as well).</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The QRegExp vs QRegularExpression situation is quite \
confusing, but the later should be preferred in Qt 5.x - it is faster if nothing \
else.</p></pre> </blockquote>
<p>On December 22nd, 2015, 5:14 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">you're right docs don't mention it, but see Alex's comment on \
https://git.reviewboard.kde.org/r/126455/</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
wasn't that I don't trust you on its thread safety. :)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just \
meant to leave it as a note for future reference if they decide to remove the 'inner \
mutex' during some code clean-up and optimization attempts.</p></pre> <br />
<p>- Ivan</p>
<br />
<p>On December 22nd, 2015, 4:52 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2015, 4:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A static QRegExp was used but it is not thread safe. \
QRegularExpression seems to be.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 352356</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I ran the autotests which includes urifilter and I've \
run krunner which uses it extensively.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/urifilters/shorturi/kshorturifilter.cpp <span style="color: \
grey">(1af4768b7b5ab9d1f5af52f17170d466d854b9bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126474/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0265423132539772866==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic