[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126423: KPluginSelector::addPlugins: do not assert if 'config' parameter is null
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2015-12-21 8:55:15
Message-ID: 20151221085515.32218.65282 () mimi ! kde ! org
[Download RAW message or body]
--===============4596391645359267143==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126423/
-----------------------------------------------------------
(Updated Dec. 21, 2015, 8:55 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
-------
Submitted with commit 1ae59b5f0ea4f50b7350f03fd2b1fe223f66a261 by Jonathan Marten to \
branch master.
Bugs: 352471
https://bugs.kde.org/show_bug.cgi?id=352471
Repository: kcmutils
Description
-------
The API documentation says that the 4-argument form of KPluginSelector::addPlugins() \
can be called with the last 'config' parameter as null (the default), meaning the \
standard application config file. However, there seems to be a misplaced assert \
which means that this will not be accepted.
Diffs
-----
src/kpluginselector.cpp 34a7897
Diff: https://git.reviewboard.kde.org/r/126423/diff/
Testing
-------
Built kcmutils with this change, checked with Konqueror's "Configure Extensions" \
dialogue as described in the bug report. Observed assert/crash without this change, \
and correct operation with it.
Thanks,
Jonathan Marten
--===============4596391645359267143==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126423/">https://git.reviewboard.kde.org/r/126423/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2015, 8:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 1ae59b5f0ea4f50b7350f03fd2b1fe223f66a261 by \
Jonathan Marten to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=352471">352471</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcmutils
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The API documentation says that the 4-argument form of \
KPluginSelector::addPlugins() can be called with the last 'config' parameter \
as null (the default), meaning the standard application config file. However, there \
seems to be a misplaced assert which means that this will not be accepted.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kcmutils with this change, checked with Konqueror's \
"Configure Extensions" dialogue as described in the bug report. Observed \
assert/crash without this change, and correct operation with it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kpluginselector.cpp <span style="color: grey">(34a7897)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126423/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4596391645359267143==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic