[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126348: Make it possible to provide the metadata in json
From: "Alex Richardson" <arichardson.kde () gmail ! com>
Date: 2015-12-14 17:58:33
Message-ID: 20151214175833.7434.55944 () mimi ! kde ! org
[Download RAW message or body]
--===============4890663066740082657==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126348/#review89482
-----------------------------------------------------------
Can't really comment on KPackage internals, but looks good to me other than this one \
issue
src/kpackage/private/packagejobthread.cpp (line 143)
<https://git.reviewboard.kde.org/r/126348/#comment61242>
I think it would be better if this code was added to the KPluginMetaData ctor (in \
an `if (path.endswith(".json"))` branch.
- Alex Richardson
On Dec. 14, 2015, 5:11 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126348/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 5:11 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kpackage
>
>
> Description
> -------
>
> Due to KCoreAddons transition from using desktop files to json files, KPackage \
> ended in a weird state where desktop files were allowed to use desktop files but \
> not json.
> This patch makes sure that manifest.json files are also acceptable.
>
>
> Diffs
> -----
>
> autotests/querytest.cpp 0a2f11a
> src/kpackage/package.cpp 8416054
> src/kpackage/packageloader.cpp 1e1e382
> src/kpackage/private/packagejobthread.cpp 444dacc
> src/kpackage/private/packagejobthread_p.h 1babf0b
> src/kpackage/private/packages.cpp 2f6bbcf
>
> Diff: https://git.reviewboard.kde.org/r/126348/diff/
>
>
> Testing
> -------
>
> Tests still pass (except for \
> https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, \
> that is not passing in master). Adds a test plugin with a json file in it.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============4890663066740082657==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126348/">https://git.reviewboard.kde.org/r/126348/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can't \
really comment on KPackage internals, but looks good to me other than this one \
issue</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126348/diff/1/?file=422766#file422766line143" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kpackage/private/packagejobthread.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">143</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QFile</span> <span class="n">f</span><span class="p">(</span><span \
class="n">path</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think it would be better if this code was added to the KPluginMetaData ctor (in an \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">if (path.endswith(".json"))</code> \
branch.</p></pre> </div>
</div>
<br />
<p>- Alex Richardson</p>
<br />
<p>On December 14th, 2015, 5:11 p.m. GMT, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2015, 5:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Due to KCoreAddons transition from using desktop files \
to json files, KPackage ended in a weird state where desktop files were allowed to \
use desktop files but not json.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch makes sure \
that manifest.json files are also acceptable.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tests still pass (except for \
https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, \
that is not passing in master). Adds a test plugin with a json file in it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/querytest.cpp <span style="color: grey">(0a2f11a)</span></li>
<li>src/kpackage/package.cpp <span style="color: grey">(8416054)</span></li>
<li>src/kpackage/packageloader.cpp <span style="color: grey">(1e1e382)</span></li>
<li>src/kpackage/private/packagejobthread.cpp <span style="color: \
grey">(444dacc)</span></li>
<li>src/kpackage/private/packagejobthread_p.h <span style="color: \
grey">(1babf0b)</span></li>
<li>src/kpackage/private/packages.cpp <span style="color: \
grey">(2f6bbcf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126348/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4890663066740082657==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic