[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/S
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2015-12-14 16:04:16
Message-ID: 20151214160416.7434.17450 () mimi ! kde ! org
[Download RAW message or body]
--===============7381893197250719189==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126324/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 5:04 p.m.)
Review request for KDE Software on Mac OS X and KDE Frameworks.
Changes
-------
Version taking the various issues into account.
I've reimplemented the (IMHO) relevant bits of QWidget::saveGeometry and \
QWidget::restoreGeometry as a class, in hope it might be reusable.
This works to satisfaction on OS X, and hopefully will do so on MS Windows too.
Restoring window size *and* position without a dedicated function that handles both aspects is \
often tricky (and platform dependent). QWidget::restoreGeometry is much more complex and it is \
well possible that is better capable to handle all possible interactions between size and \
position. I suppose time will tell.
Repository: kconfig
Description
-------
In KDElibs4, the KMainWindow::saveWindowSize() and KMainWindow::restoreWindowSize() function \
saved and restored not only the size but also the position (i.e. the geometry) of windows, \
using QWidget::saveGeometry and QWidget::restoreGeometry.
2 main reasons for this (according to the comments):
- Under X11 restoring the position is tricky
- X11 has a window manager which might be considered responsible for that functionality (and I \
suppose most modern WMs have the feature enabled by default?)
Both arguments are moot on MS Windows and OS X, and on both platforms users expect to see \
window positions restored as well as window size. On OS X there is also little choice in the \
matter: most applications offer the geometry restore without asking (IIRC it is the same on MS \
Windows).
I would thus like to propose to port the platform-specific code that existed for MS Windows \
(and for OS X as a MacPorts patch that apparently was never submitted upstreams). I realise \
that this violates the message conveyed by the function names but I would like to think that \
this is a case where function is more important.
You may also notice that the Mac version does not store resolution-specific settings. This \
happens to work best on OS X, where multi-screen support has been present since the early \
nineties, and where window geometry is restored regardless of the screen resolution (i.e. \
connect a different external screen with a different resolution, and windows will reopen as \
they were on that screen, not with some default geometry). I required I can update the comments \
in the header to reflect this subtlety.
Note that for optimal functionality a companion patch to `KMainWindow::event` is required:
```
--- a/src/kmainwindow.cpp
+++ b/src/kmainwindow.cpp
@@ -772,7 +772,7 @@ bool KMainWindow::event(QEvent *ev)
{
K_D(KMainWindow);
switch (ev->type()) {
-#ifdef Q_OS_WIN
+#if defined(Q_OS_WIN) || defined(Q_OS_OSX)
case QEvent::Move:
#endif
case QEvent::Resize:
```
This ensures that the window geometry save is performed also after a move (to update the \
position) without requiring a dummy resizing operation. Do I need to create a separate RR for \
this change or is it small enough that I can push it if and when this RR is accepted?
Diffs (updated)
-----
src/gui/kwindowconfig.h 48a8f3c
src/gui/kwindowconfig.cpp d2f355c
Diff: https://git.reviewboard.kde.org/r/126324/diff/
Testing
-------
On OS X 10.6 through 10.9 with various KDElibs4 versions and now with Qt 5.5.1 and frameworks \
5.16.0 (and Kate as a test application). I presume that the MS Windows code has been tested \
sufficiently in KDELibs4; I have only adapted it to Qt5 and tested if it builds.
Thanks,
René J.V. Bertin
--===============7381893197250719189==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126324/">https://git.reviewboard.kde.org/r/126324/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and KDE Frameworks.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2015, 5:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Version taking the \
various issues into account. I've reimplemented the (IMHO) relevant bits of \
QWidget::saveGeometry and QWidget::restoreGeometry as a class, in hope it might be reusable.
This works to satisfaction on OS X, and hopefully will do so on MS Windows too.
Restoring window size *and* position without a dedicated function that handles both aspects is \
often tricky (and platform dependent). QWidget::restoreGeometry is much more complex and it is \
well possible that is better capable to handle all possible interactions between size and \
position. I suppose time will tell.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In KDElibs4, \
the KMainWindow::saveWindowSize() and KMainWindow::restoreWindowSize() function saved and \
restored not only the size but also the position (i.e. the geometry) of windows, using \
QWidget::saveGeometry and QWidget::restoreGeometry.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">2 main reasons for this \
(according to the comments):
- Under X11 restoring the position is tricky
- X11 has a window manager which might be considered responsible for that functionality (and I \
suppose most modern WMs have the feature enabled by default?)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Both arguments \
are moot on MS Windows and OS X, and on both platforms users expect to see window positions \
restored as well as window size. On OS X there is also little choice in the matter: most \
applications offer the geometry restore without asking (IIRC it is the same on MS Windows).</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I would thus like to propose to port the platform-specific code that existed for MS \
Windows (and for OS X as a MacPorts patch that apparently was never submitted upstreams). I \
realise that this violates the message conveyed by the function names but I would like to think \
that this is a case where function is more important.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">You may also notice that the Mac \
version does not store resolution-specific settings. This happens to work best on OS X, where \
multi-screen support has been present since the early nineties, and where window geometry is \
restored regardless of the screen resolution (i.e. connect a different external screen with a \
different resolution, and windows will reopen as they were on that screen, not with some \
default geometry). I required I can update the comments in the header to reflect this \
subtlety.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Note that for optimal functionality a companion patch to <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">KMainWindow::event</code> is required:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span \
style="color: #A00000">--- a/src/kmainwindow.cpp</span> <span style="color: #00A000">+++ \
b/src/kmainwindow.cpp</span> <span style="color: #800080; font-weight: bold">@@ -772,7 +772,7 \
@@ bool KMainWindow::event(QEvent *ev)</span> {
K_D(KMainWindow);
switch (ev->type()) {
<span style="color: #A00000">-#ifdef Q_OS_WIN</span>
<span style="color: #00A000">+#if defined(Q_OS_WIN) || defined(Q_OS_OSX)</span>
case QEvent::Move:
#endif
case QEvent::Resize:
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This ensures that the window geometry save is performed also after a move (to update \
the position) without requiring a dummy resizing operation. Do I need to create a separate RR \
for this change or is it small enough that I can push it if and when this RR is \
accepted?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.6 \
through 10.9 with various KDElibs4 versions and now with Qt 5.5.1 and frameworks 5.16.0 (and \
Kate as a test application). I presume that the MS Windows code has been tested sufficiently in \
KDELibs4; I have only adapted it to Qt5 and tested if it builds.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/gui/kwindowconfig.h <span style="color: grey">(48a8f3c)</span></li>
<li>src/gui/kwindowconfig.cpp <span style="color: grey">(d2f355c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126324/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7381893197250719189==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic