[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-12-13 1:01:21
Message-ID: 20151213010121.3920.77362 () mimi ! kde ! org
[Download RAW message or body]
--===============7156181700878837577==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126328/#review89407
-----------------------------------------------------------
i suggest using:
#ifdef Q_OS_WIN
#define U QLatin1String
#else
#define U QStringLiteral
#endif
- Nick Shaforostoff
On Dec. 12, 2015, 10:59 p.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126328/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 10:59 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kwallet
>
>
> Description
> -------
>
> Strings that are separated into multiple parts don't work on Windows
> together with QStringLiteral as the first string is interpreted as a
> wide (16bit) string, and the second one as a narrow (8bit) string.
> Replacing with QString::fromLatin1 is the easiest solution keeping
> the code layout the same, joining the strings does work too though.
>
>
> Diffs
> -----
>
> src/runtime/kwalletd/kwalletd.cpp 5f99f161a0911732c4d46ab36f2e4f3d3f3e3c4b
>
> Diff: https://git.reviewboard.kde.org/r/126328/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Patrick Spendrin
>
>
--===============7156181700878837577==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126328/">https://git.reviewboard.kde.org/r/126328/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i suggest using:
#ifdef Q_OS_WIN
#define U QLatin1String
#else
#define U QStringLiteral
#endif</pre>
<br />
<p>- Nick Shaforostoff</p>
<br />
<p>On December 12th, 2015, 10:59 p.m. UTC, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2015, 10:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Strings that are separated into multiple parts don't work on Windows \
together with QStringLiteral as the first string is interpreted as a wide (16bit) \
string, and the second one as a narrow (8bit) string. Replacing with \
QString::fromLatin1 is the easiest solution keeping the code layout the same, joining \
the strings does work too though.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/runtime/kwalletd/kwalletd.cpp <span style="color: \
grey">(5f99f161a0911732c4d46ab36f2e4f3d3f3e3c4b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126328/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7156181700878837577==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic