'Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden
From:       "David Faure" <faure () kde ! org>
Date:       2015-12-12 21:02:29
Message-ID: 20151212210229.3920.76436 () mimi ! kde ! org
[Download RAW message or body]

--===============7098413717671934471==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125988/#review89400
-----------------------------------------------------------

Ah I needed the last hunk from your patch, too. Now it works. \
http://www.davidfaure.fr/2015/0001-Add-autocompletion-for-.-input-which-offers-all-hidd.patch \
ok with you?

- David Faure

On Nov. 28, 2015, 9:36 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125988/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2015, 9:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 354981
> https://bugs.kde.org/show_bug.cgi?id=354981
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Currently KUrlCompletion only offers autocompletion for hidden folders when you \
> input at least one additional character after the dot.  With this patch all hidden \
> folders will be offered when only a dot is present. 
> This behaviour is test covered.
> 
> 
> Diffs
> -----
> 
> autotests/kurlcompletiontest.cpp ca8563c 
> src/widgets/kurlcompletion.cpp c6764e4 
> 
> Diff: https://git.reviewboard.kde.org/r/125988/diff/
> 
> 
> Testing
> -------
> 
> All test cases for KUrlCompletion pass
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
> 

--===============7098413717671934471==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125988/">https://git.reviewboard.kde.org/r/125988/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah I \
needed the last hunk from your patch, too. Now it works. \
http://www.davidfaure.fr/2015/0001-Add-autocompletion-for-.-input-which-offers-all-hidd.patch \
ok with you?</p></pre>  <br />

<p>- David Faure</p>

<br />
<p>On November 28th, 2015, 9:36 p.m. UTC, Emmanuel Pescosta wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Emmanuel Pescosta.</div>

<p style="color: grey;"><i>Updated Nov. 28, 2015, 9:36 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=354981">354981</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently KUrlCompletion only offers autocompletion \
for hidden folders when you input at least one additional character after the dot.  \
With this patch all hidden folders will be offered when only a dot is present.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This behaviour is test covered.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">All test cases for KUrlCompletion pass</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kurlcompletiontest.cpp <span style="color: grey">(ca8563c)</span></li>

 <li>src/widgets/kurlcompletion.cpp <span style="color: grey">(c6764e4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125988/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7098413717671934471==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 