[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a93
From: "David Faure" <faure () kde ! org>
Date: 2015-12-12 18:45:27
Message-ID: 20151212184527.3920.76178 () mimi ! kde ! org
[Download RAW message or body]
--===============3623443636747463670==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126295/#review89398
-----------------------------------------------------------
Ship it!
We could findChildren in an autotest to find the buttons and check their number and \
the text on each one.
src/filewidgets/kurlnavigator.cpp (line 371)
<https://git.reviewboard.kde.org/r/126295/#comment61153>
No need for PreferLocalFile anymore, the url is always remote. My code was \
correct :)
- David Faure
On Dec. 12, 2015, 11:11 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126295/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 11:11 a.m.)
>
>
> Review request for KDE Frameworks, David Faure and Emmanuel Pescosta.
>
>
> Repository: kio
>
>
> Description
> -------
>
> 9dbe36f734b5b839b2a6a934fad29d639e954498 breaks some assumption on startIndex. The \
> argument index passed to buttonUrl is based number of '/'in full url. Because of \
> that, url like "sftp://a@b.com/a/b" is now shown as "sftp:a@b.com" / "b" / "b" in \
> dolphin url bar.
> This patch changes all relevant code that calls buttonUrl() to use url.path() \
> instead of url.toDisplayString() to count the number of "/".
>
> Diffs
> -----
>
> src/filewidgets/kurlnavigator.cpp 848e98b
>
> Diff: https://git.reviewboard.kde.org/r/126295/diff/
>
>
> Testing
> -------
>
> Remote url -> ok
> Local url -> ok
> Remote url in places and try browse some sub folder -> ok
> Local url in places and try browse some sub folder -> ok
>
>
> Thanks,
>
> Xuetian Weng
>
>
--===============3623443636747463670==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126295/">https://git.reviewboard.kde.org/r/126295/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We \
could findChildren in an autotest to find the buttons and check their number and the \
text on each one.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126295/diff/3/?file=421867#file421867line371" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/filewidgets/kurlnavigator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KUrlNavigator::Private::openPathSelectorMenu()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">371</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">dirName</span> <span class="o">=</span> <span \
class="n">placeUrl</span><span class="p">.</span><span \
class="n">toDisplayString</span><span class="p">(</span><span \
class="n">QUrl</span><span class="o">::</span><span \
class="n">PreferLocalFile</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No \
need for PreferLocalFile anymore, the url is always remote. My code was correct \
:)</p></pre> </div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On December 12th, 2015, 11:11 a.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Emmanuel Pescosta.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2015, 11:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">9dbe36f734b5b839b2a6a934fad29d639e954498 breaks some \
assumption on startIndex. The argument index passed to buttonUrl is based number of \
'/'in full url. Because of that, url like "sftp://a@b.com/a/b" is now shown as \
"sftp:a@b.com" / "b" / "b" in dolphin url bar.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch changes all relevant code that calls buttonUrl() to use url.path() instead of \
url.toDisplayString() to count the number of "/".</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remote url -> ok Local url -> ok
Remote url in places and try browse some sub folder -> ok
Local url in places and try browse some sub folder -> ok</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/filewidgets/kurlnavigator.cpp <span style="color: \
grey">(848e98b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126295/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3623443636747463670==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic