[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process
From: "David Faure" <faure () kde ! org>
Date: 2015-12-10 8:23:12
Message-ID: 20151210082312.3920.63706 () mimi ! kde ! org
[Download RAW message or body]
--===============8304456207719525571==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123229/#review89297
-----------------------------------------------------------
OK, at least it makes more sense to me now. We register at QCoreApp construction \
time, even though it's slightly too early (we would want QApp construction time, but \
no mechanism for that) because doing it earlier is useless. And then we check for \
QApp in the code. OK.
src/widgets/kdynamicjobtracker.cpp (line 89)
<https://git.reviewboard.kde.org/r/123229/#comment61065>
this check should also be done on line 76 where another KWidgetJobTracker is \
being created, then.
- David Faure
On Dec. 7, 2015, 1:29 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123229/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2015, 1:29 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Prevents the UiDelegate and UiTracker to get initialized, because they'll try to \
> create windows and dialogs when some things happen and these will immediately end \
> in a crash.
>
> Diffs
> -----
>
> src/widgets/kdynamicjobtracker.cpp 14924d5
>
> Diff: https://git.reviewboard.kde.org/r/123229/diff/
>
>
> Testing
> -------
>
> Ran the tests, my unit test doesn't crash anymore.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============8304456207719525571==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123229/">https://git.reviewboard.kde.org/r/123229/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, \
at least it makes more sense to me now. We register at QCoreApp construction time, \
even though it's slightly too early (we would want QApp construction time, but no \
mechanism for that) because doing it earlier is useless. And then we check for QApp \
in the code. OK.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123229/diff/3/?file=421362#file421362line89" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/widgets/kdynamicjobtracker.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KDynamicJobTracker::registerJob(KJob *job)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">88</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">QDBusConnection</span><span class="o">::</span><span \
class="n">sessionBus</span><span class="p">(),</span> <span \
class="k">this</span><span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">89</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">qobject_cast</span><span \
class="o"><</span><span class="n">QApplication</span><span \
class="o">*></span><span class="p">(</span><span \
class="n">QCoreApplication</span><span class="o">::</span><span \
class="n">instance</span><span class="p">()))</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
check should also be done on line 76 where another KWidgetJobTracker is being \
created, then.</p></pre> </div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On December 7th, 2015, 1:29 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Dec. 7, 2015, 1:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Prevents the UiDelegate and UiTracker to get \
initialized, because they'll try to create windows and dialogs when some things \
happen and these will immediately end in a crash.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran the tests, my unit test doesn't crash \
anymore.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/kdynamicjobtracker.cpp <span style="color: \
grey">(14924d5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123229/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8304456207719525571==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic