[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged action
From: "David Faure" <faure () kde ! org>
Date: 2015-12-06 14:58:15
Message-ID: 20151206145815.29696.95299 () mimi ! kde ! org
[Download RAW message or body]
--===============4291373873473420532==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126184/#review89183
-----------------------------------------------------------
src/kedittoolbar.cpp (line 770)
<https://git.reviewboard.kde.org/r/126184/#comment61017>
this code path didn't call accept() before.
Please investigate when save can fail, or keep former behaviour (by adding \
"return;").
- David Faure
On Nov. 27, 2015, 1:40 p.m., Jean-Baptiste Mardelle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126184/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 1:40 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Bugs: 352882
> https://bugs.kde.org/show_bug.cgi?id=352882
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> To Reproduce: in a KXmlGuiWindow, open the Configure Toolbars dialog.
> 1 - Change the main toolbar setting.
> 2 - Click Apply, the ui is rebuild, and the newToolBarConfig signal is emitted, \
> allowing main app to re-plug its dynamic actions 3 - Click Ok, the ui is rebuild \
> but the signal is not emitted, so app cannot re-plug actions, and they are lost.
> The problem only happens if you click "apply" and then "ok". This is due to the \
> fact that when Ok is clicked, the ui is rebuild (m_widget->save triggers ui \
> rebuild), but signal is not emitted.
> My solution is to rebuild ui only if something changed when clicking "ok".
>
>
> Diffs
> -----
>
> src/kedittoolbar.cpp ba4ba0f
>
> Diff: https://git.reviewboard.kde.org/r/126184/diff/
>
>
> Testing
> -------
>
> Tested, fixes the reported problem.
>
>
> Thanks,
>
> Jean-Baptiste Mardelle
>
>
--===============4291373873473420532==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126184/">https://git.reviewboard.kde.org/r/126184/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126184/diff/1/?file=418635#file418635line770" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kedittoolbar.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KEditToolBarPrivate::okClicked()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">770</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// \
button was already pressed and no further changes were made.</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">770</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">// some error box here is needed</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
code path didn't call accept() before.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Please investigate when \
save can fail, or keep former behaviour (by adding "return;").</p></pre> </div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On November 27th, 2015, 1:40 p.m. UTC, Jean-Baptiste Mardelle wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Jean-Baptiste Mardelle.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2015, 1:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=352882">352882</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To Reproduce: in a KXmlGuiWindow, open the Configure \
Toolbars dialog. 1 - Change the main toolbar setting.
2 - Click Apply, the ui is rebuild, and the newToolBarConfig signal is emitted, \
allowing main app to re-plug its dynamic actions 3 - Click Ok, the ui is rebuild but \
the signal is not emitted, so app cannot re-plug actions, and they are lost.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The problem only happens if you click "apply" and then "ok". This is due to \
the fact that when Ok is clicked, the ui is rebuild (m_widget->save triggers ui \
rebuild), but signal is not emitted.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">My solution is to \
rebuild ui only if something changed when clicking "ok".</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested, fixes the reported problem.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kedittoolbar.cpp <span style="color: grey">(ba4ba0f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126184/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4291373873473420532==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic