'Re: Review Request 125800: OS X build and warning fix'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 125800: OS X build and warning fix
From:       "David Faure" <faure () kde ! org>
Date:       2015-12-06 10:45:02
Message-ID: 20151206104502.29696.83812 () mimi ! kde ! org
[Download RAW message or body]

--===============1615675823333811006==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125800/#review89165
-----------------------------------------------------------

Ship it!

Ship It!

- David Faure

On Oct. 27, 2015, 11:01 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125800/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Romanov.
> 
> 
> Repository: qca
> 
> 
> Description
> -------
> 
> The cmake find file was missing, but CoreFoundation being a system
> framework, no need to search for it.
> 
> OS X: Update code to not use deprecated functions/data structure
> 
> CSSM_DATA and SecCertificateGetData have been deprecated since 10.7.
> This patch uses SecCertificateCopyData which is the official
> replacement.
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt dbce08272deb284f3cb0fd09ccfec4ab93ce3e23 
> src/CMakeLists.txt a60bda0bf3d8bad7523ee7d50798c8cdb6c2eccb 
> src/qca_systemstore_mac.cpp 9349c90c8258d3d1f00a3796d93f94c09f5b1f2a 
> 
> Diff: https://git.reviewboard.kde.org/r/125800/diff/
> 
> 
> Testing
> -------
> 
> Build on OS X 10.8
> 
> Check that qcatool-qt5 keystore list-stores returns the same results
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
> 

--===============1615675823333811006==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125800/">https://git.reviewboard.kde.org/r/125800/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- David Faure</p>

<br />
<p>On October 27th, 2015, 11:01 p.m. UTC, Samuel Gaist wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Ivan Romanov.</div>
<div>By Samuel Gaist.</div>

<p style="color: grey;"><i>Updated Oct. 27, 2015, 11:01 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
qca
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The cmake find file was missing, but CoreFoundation being a system \
framework, no need to search for it.

OS X: Update code to not use deprecated functions/data structure

CSSM_DATA and SecCertificateGetData have been deprecated since 10.7.
This patch uses SecCertificateCopyData which is the official
replacement.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build on OS X 10.8</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Check \
that qcatool-qt5 keystore list-stores returns the same results</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(dbce08272deb284f3cb0fd09ccfec4ab93ce3e23)</span></li>

 <li>src/CMakeLists.txt <span style="color: \
grey">(a60bda0bf3d8bad7523ee7d50798c8cdb6c2eccb)</span></li>

 <li>src/qca_systemstore_mac.cpp <span style="color: \
grey">(9349c90c8258d3d1f00a3796d93f94c09f5b1f2a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125800/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1615675823333811006==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 