'Re: Review Request 126149: [Icon widget] Bring back properties dialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126149: [Icon widget] Bring back properties dialog
From:       "David Faure" <faure () kde ! org>
Date:       2015-12-02 7:57:08
Message-ID: 20151202075708.29696.42326 () mimi ! kde ! org
[Download RAW message or body]

--===============6769115100731945720==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review89023
-----------------------------------------------------------

applets/icon/plugin/icon_p.cpp (line 203)
<https://git.reviewboard.kde.org/r/126149/#comment60948>

    PreferLocalFile is only good for displaying to the user. Otherwise you have \
something which is "a path or a URL", and most API doesn't work with that.

applets/icon/plugin/icon_p.cpp (line 205)
<https://git.reviewboard.kde.org/r/126149/#comment60949>

    This only works with local files, so it should be in a if (m_url.isLocalFile()) \
block, and use m_url.toLocalFile(). The current code would break on Windows at least, \
and possibly in case of filenames with '#'.  
    Put the result of toLocalFile() in a temporary QString, you'll need further down \
as well.

applets/icon/plugin/icon_p.cpp (line 211)
<https://git.reviewboard.kde.org/r/126149/#comment60950>

    Yes, don't ;)

    Actually this is a local-to-local copy, you could just use QFile::copy if you \
want it synchronous.

applets/icon/plugin/icon_p.cpp (line 239)
<https://git.reviewboard.kde.org/r/126149/#comment60951>

    why commented out?

- David Faure

On Nov. 26, 2015, 8:15 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 8:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This has \
> been requested at multiple occasions. This has been adapted from the Plasma 4 icon \
> code. 
> 
> Diffs
> -----
> 
> applets/icon/package/contents/ui/main.qml 9286b94 
> applets/icon/plugin/icon_p.h dd7963c 
> applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> -------
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, \
> allowing to rename it. The applet reflected the changes. 
> Dropped an application from kickoff to the desktop -> dialog from a copy of the \
> desktop file, allowing to change its icon and description. The applet reflected the \
> changes. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============6769115100731945720==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126149/">https://git.reviewboard.kde.org/r/126149/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126149/diff/1/?file=417967#file417967line203" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/icon/plugin/icon_p.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">203</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">const</span> <span class="n">QString</span> <span \
class="o">&amp;</span><span class="n">stringUrl</span> <span class="o">=</span> <span \
class="n">m_url</span><span class="p">.</span><span class="n">toString</span><span \
class="p">(</span><span class="n">QUrl</span><span class="o">::</span><span \
class="n">PreferLocalFile</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">PreferLocalFile is only good for displaying to the user. Otherwise you have \
something which is "a path or a URL", and most API doesn't work with that.</p></pre>  \
</div> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126149/diff/1/?file=417967#file417967line205" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/icon/plugin/icon_p.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">205</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span><span class="n">KDesktopFile</span><span \
class="o">::</span><span class="n">isDesktopFile</span><span class="p">(</span><span \
class="n">stringUrl</span><span class="p">))</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
only works with local files, so it should be in a if (m_url.isLocalFile()) block, and \
use m_url.toLocalFile(). The current code would break on Windows at least, and \
possibly in case of filenames with '#'.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Put the result of \
toLocalFile() in a temporary QString, you'll need further down as well.</p></pre>  \
</div> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126149/diff/1/?file=417967#file417967line211" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/icon/plugin/icon_p.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">211</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="n">job</span><span class="o">-&gt;</span><span \
class="n">exec</span><span class="p">();</span> <span class="c1">// FIXME don&#39;t \
exec()</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
don't ;)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Actually this is a local-to-local copy, you could just \
use QFile::copy if you want it synchronous.</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126149/diff/1/?file=417967#file417967line239" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/icon/plugin/icon_p.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">239</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">       <span \
class="c1">// dialog-&gt;setWindowTitle(i18n(&quot;%1 Icon Settings&quot;, \
m_url.fileName()));</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why \
commented out?</p></pre>  </div>
</div>
<br />

<p>- David Faure</p>

<br />
<p>On November 26th, 2015, 8:15 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2015, 8:15 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=?">?</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This brings back the KPropertiesDialog to modify an \
icon's appearance. This has been requested at multiple occasions. This has been \
adapted from the Plasma 4 icon code.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Dropped a file from my home onto the desktop -&gt; \
dialog from the actual file, allowing to rename it. The applet reflected the \
changes.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Dropped an application from kickoff to the desktop \
-&gt; dialog from a copy of the desktop file, allowing to change its icon and \
description. The applet reflected the changes.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/icon/package/contents/ui/main.qml <span style="color: \
grey">(9286b94)</span></li>

 <li>applets/icon/plugin/icon_p.h <span style="color: grey">(dd7963c)</span></li>

 <li>applets/icon/plugin/icon_p.cpp <span style="color: grey">(e086870)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126149/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6769115100731945720==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 