[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2015-11-25 18:12:28
Message-ID: 20151125181228.23104.99762 () mimi ! kde ! org
[Download RAW message or body]
--===============3383655814782426272==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126170/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 7:12 p.m.)
Review request for KDE Software on Mac OS X and KDE Frameworks.
Changes
-------
Achieve the same (hopefully!) effect by setting \
`QT_MAC_DISABLE_FOREGROUND_APPLICATION_TRANSFORM`.
`kded` is supposed to be a true daemon that doesn't even have a "systray" presence, \
so this mechanism may be suitable or even more appropriate. Time will have to tell.
What bothers me is that feature isn't documented, and also that it works differently \
from setting `LSUIElement`. If I read \
`qt_mac_transformProccessToForegroundApplication()` correctly, it is indeed the \
equivalent of setting `LSBackgrounOnly`, and that is *probably* inappropriate for \
applications that do need to become foreground for instance to post a dialog.
Repository: kded
Description
-------
There should be no reason to build `kded5` as an app bundle on OS X, and with recent \
feedback in mind I postulated that marking it "nongui" \
(`ecm_mark_nongui_application`) would be acceptable on other platforms too.
Additionally, `kded5` doesn't have any more reason to appear in the Dock or app \
switcher, on OS X, so I have added the code to make it an agent.
Diffs (updated)
-----
CMakeLists.txt 4b9a5ff
src/CMakeLists.txt 5e95df8
src/kded.cpp 6929d7d
Diff: https://git.reviewboard.kde.org/r/126170/diff/
Testing
-------
On OS X 10.9.5 with Qt 5.5.1 and FWs 5.16.0 .
Thanks,
René J.V. Bertin
--===============3383655814782426272==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126170/">https://git.reviewboard.kde.org/r/126170/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and KDE Frameworks.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2015, 7:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Achieve the same (hopefully!) effect by setting \
`QT_MAC_DISABLE_FOREGROUND_APPLICATION_TRANSFORM`.
`kded` is supposed to be a true daemon that doesn't even have a \
"systray" presence, so this mechanism may be suitable or even more \
appropriate. Time will have to tell.
What bothers me is that feature isn't documented, and also that it works \
differently from setting `LSUIElement`. If I read \
`qt_mac_transformProccessToForegroundApplication()` correctly, it is indeed the \
equivalent of setting `LSBackgrounOnly`, and that is *probably* inappropriate for \
applications that do need to become foreground for instance to post a dialog.</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kded
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There should be no reason to build <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">kded5</code> as an app bundle on OS X, and with recent \
feedback in mind I postulated that marking it "nongui" (<code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">ecm_mark_nongui_application</code>) would be acceptable on other platforms \
too.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Additionally, <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">kded5</code> doesn't have any more reason to appear in the Dock or app \
switcher, on OS X, so I have added the code to make it an agent.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9.5 with Qt 5.5.1 and FWs 5.16.0 \
.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4b9a5ff)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(5e95df8)</span></li>
<li>src/kded.cpp <span style="color: grey">(6929d7d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126170/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3383655814782426272==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic