'Re: Review Request 126140: [kfilemetadata] avoid utf16->utf8->utf16 conversions reading taglib metad'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126140: [kfilemetadata] avoid utf16->utf8->utf16 conversions reading taglib metad
From:       "Nick Shaforostoff" <shafff () ukr ! net>
Date:       2015-11-24 23:05:31
Message-ID: 20151124230531.23104.99053 () mimi ! kde ! org
[Download RAW message or body]

--===============1970634431507800611==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126140/
-----------------------------------------------------------

(Updated Nov. 24, 2015, 11:05 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, Juan Palacios, Pino Toscano, and Vishesh Handa.

Changes
-------

Submitted with commit 4655943a49acfa181d31a00c5aef1bf10dcba2bf by Nick Shaforostoff to branch master.

Repository: kfilemetadata

Description
-------

also this patch marks 'audio/mp4' mimetype as supported by taglib for reading .m4a files (AAC or ALAC)

Diffs
-----

  src/extractors/taglibextractor.cpp 3bf33cd 

Diff: https://git.reviewboard.kde.org/r/126140/diff/

Testing
-------

tested with Spanish accents (e.g. José, Cátulo) in the tags.

also i did test this toCWString-based conversion on windows and it worked fine. should work on osx as \
well

Thanks,

Nick Shaforostoff

--===============1970634431507800611==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126140/">https://git.reviewboard.kde.org/r/126140/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Juan Palacios, Pino Toscano, and Vishesh Handa.</div>
<div>By Nick Shaforostoff.</div>

<p style="color: grey;"><i>Updated Nov. 24, 2015, 11:05 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
4655943a49acfa181d31a00c5aef1bf10dcba2bf by Nick Shaforostoff to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">also this patch marks 'audio/mp4' mimetype \
as supported by taglib for reading .m4a files (AAC or ALAC)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">tested with Spanish accents (e.g. José, \
Cátulo) in the tags.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">also i did test this toCWString-based conversion on windows and it worked \
fine. should work on osx as well</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/extractors/taglibextractor.cpp <span style="color: grey">(3bf33cd)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126140/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1970634431507800611==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 