'Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2015-11-19 0:33:31
Message-ID: 20151119003331.14400.85678 () mimi ! kde ! org
[Download RAW message or body]

--===============5623312872616448135==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126105/#review88554
-----------------------------------------------------------

Ship it!

I'm a little hesitant about this, but ship it.

A couple of things though -
1. Dolphin should probably not be sending Baloo so many requests if Baloo is \
disabled. Perhaps we should fix this in Dolphin. 2. This patch is mostly only for the \
Baloo::File class which causes the db to be opened and closed for each operation. \
It's expensive, but the main use case that I focussed on was searching. Over there \
the db is only opened once per application.

- Vishesh Handa

On Nov. 18, 2015, 7:40 p.m., Boudhayan Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126105/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 7:40 p.m.)
> 
> 
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Add a check in Baloo::Database::open() to return false if we're opening the \
> database in ReadOnly mode and the database doesn't exist. This fixes a crash in \
> Dolphin when Baloo isn't running. 
> This isn't the entire fix - one will also have to remove ~/.local/share/baloo/index \
> to not crash anymore; this patch prevents the file from being recreated everytime \
> Baloo::Database::open() is run, and re-causing the crash. 
> 
> Diffs
> -----
> 
> src/engine/database.cpp 4f0579f 
> 
> Diff: https://git.reviewboard.kde.org/r/126105/diff/
> 
> 
> Testing
> -------
> 
> Builds, runs, doesn't crash anymore, the works.
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
> 

--===============5623312872616448135==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126105/">https://git.reviewboard.kde.org/r/126105/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm a \
little hesitant about this, but ship it.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">A couple of things \
though - 1. Dolphin should probably not be sending Baloo so many requests if Baloo is \
disabled. Perhaps we should fix this in Dolphin. 2. This patch is mostly only for the \
Baloo::File class which causes the db to be opened and closed for each operation. \
It's expensive, but the main use case that I focussed on was searching. Over there \
the db is only opened once per application.</p></pre>  <br />

<p>- Vishesh Handa</p>

<br />
<p>On November 18th, 2015, 7:40 p.m. UTC, Boudhayan Gupta wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.</div>
<div>By Boudhayan Gupta.</div>

<p style="color: grey;"><i>Updated Nov. 18, 2015, 7:40 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add a check in Baloo::Database::open() to return false \
if we're opening the database in ReadOnly mode and the database doesn't exist. This \
fixes a crash in Dolphin when Baloo isn't running.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
isn't the entire fix - one will also have to remove ~/.local/share/baloo/index to not \
crash anymore; this patch prevents the file from being recreated everytime \
Baloo::Database::open() is run, and re-causing the crash.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds, runs, doesn't crash anymore, the \
works.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/engine/database.cpp <span style="color: grey">(4f0579f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126105/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5623312872616448135==--

[Attachment #3 (text/plain)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 