[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126056: Use KDE_INSTALL_ICONDIR to install the icons
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2015-11-17 18:57:43
Message-ID: 20151117185743.14400.24799 () mimi ! kde ! org
[Download RAW message or body]
--===============4050351250887929670==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126056/#review88499
-----------------------------------------------------------
icons/CMakeLists.txt (line 9)
<https://git.reviewboard.kde.org/r/126056/#comment60632>
I suspect this call *does* actually need the absolute path.
- Alex Merry
On Nov. 17, 2015, 12:42 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126056/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 12:42 p.m.)
>
>
> Review request for KDE Frameworks and Uri Herrera.
>
>
> Repository: breeze-icons
>
>
> Description
> -------
>
> It was previously hard-coded to prefix/share which is not helpful on a
> multiarch layout, where the prefix might be something like /usr/${arch}
> but arch independent files should still go into /usr/share.
>
> Also clean up unecessary cmake code. "cmake_minimum_required(VERSION 2.8)"
> was already set to a higher value in the root CMakeLists.txt, same for
> "set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")".
> Furthermore I couldn't find any '*.sh' files in the repo.
>
> REVIEW: 126056
>
>
> Diffs
> -----
>
> icons-dark/CMakeLists.txt f039db19e1df89f62a33dc323cf0b8344d9b33fd
> icons/CMakeLists.txt 6c6e3b7efb6ca1490ed52356beaf06c4e181fee0
>
> Diff: https://git.reviewboard.kde.org/r/126056/diff/
>
>
> Testing
> -------
>
> Icons get installed into the desired location.
>
>
> Thanks,
>
> Heiko Becker
>
>
--===============4050351250887929670==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126056/">https://git.reviewboard.kde.org/r/126056/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126056/diff/2/?file=417174#file417174line21" \
style="color: black; font-weight: bold; text-decoration: \
underline;">icons/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">21</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">gtk_update_icon_cache</span><span class="p">(</span><span \
class="o">${</span><span class="nv">BREEZE_INSTALL_DIR</span><span \
class="o">}</span><span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">9</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">gtk_update_icon_cache</span><span class="p">(</span><span \
class="o">${</span><span class="nv">BREEZE_INSTALL_DIR</span><span \
class="o">}</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
suspect this call <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">does</em> actually need the absolute \
path.</p></pre> </div>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On November 17th, 2015, 12:42 p.m. UTC, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Uri Herrera.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated Nov. 17, 2015, 12:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze-icons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It was previously hard-coded to prefix/share which is \
not helpful on a multiarch layout, where the prefix might be something like \
/usr/${arch} but arch independent files should still go into /usr/share.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also clean up unecessary cmake code. \
"cmake_minimum_required(VERSION 2.8)" was already set to a higher value in the root \
CMakeLists.txt, same for "set (CMAKE_MODULE_PATH \
"${CMAKE_CURRENT_SOURCE_DIR}/cmake")". Furthermore I couldn't find any '*.sh' files \
in the repo.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">REVIEW: 126056</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Icons get installed into the desired location.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>icons-dark/CMakeLists.txt <span style="color: \
grey">(f039db19e1df89f62a33dc323cf0b8344d9b33fd)</span></li>
<li>icons/CMakeLists.txt <span style="color: \
grey">(6c6e3b7efb6ca1490ed52356beaf06c4e181fee0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126056/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4050351250887929670==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic