[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-11-09 10:45:39
Message-ID: 20151109104539.23976.97307 () mimi ! kde ! org
[Download RAW message or body]
--===============2756754694925350363==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 9, 2015, 10:42 a.m., Nick Shaforostoff wrote:
> > src/ktar.cpp, line 293
> > <https://git.reviewboard.kde.org/r/126002/diff/1/?file=415780#file415780line293>
> >
> > why can't we just use QFile::decodeName(const char * localFileName) overload?
ok, there is a limit of 100. then i suggest using QByteArray::fromRawData(buffer, \
qstrnlen(buffer, 100)) because qbytearray object is 100% temporary.
- Nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126002/#review88178
-----------------------------------------------------------
On Nov. 9, 2015, 7:54 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126002/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 7:54 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> Fix KArchive for behavior change in Qt 5.6
>
> Embedded NULs are now preserved when converting from QByteArray to QString.
>
> + remove unused var (separate commit)
>
>
> Diffs
> -----
>
> autotests/karchivetest.cpp d9662f5faadf9f08f71a386c0f9ecc8ef89af23a
> src/karchive.cpp e0a1eb2245767f9d605c44a6da481d290c2b15a5
> src/ktar.cpp 824395e72e73b23f974614d5eff1fa58c7729dc0
>
> Diff: https://git.reviewboard.kde.org/r/126002/diff/
>
>
> Testing
> -------
>
> karchivetest passes again, with Qt 5.6 from git.
>
> I complained about the behavior change on https://codereview.qt-project.org/106473
>
>
> Thanks,
>
> David Faure
>
>
--===============2756754694925350363==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126002/">https://git.reviewboard.kde.org/r/126002/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 9th, 2015, 10:42 a.m. UTC, <b>Nick \
Shaforostoff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126002/diff/1/?file=415780#file415780line293" \
style="color: black; font-weight: bold; text-decoration: underline;">src/ktar.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">qint64 \
KTar::KTarPrivate::readHeader(char *buffer, QString &name, QString \
&symlink)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">292</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">name</span> <span class="o">=</span> <span class="n">QFile</span><span \
class="o">::</span><span class="n">decodeName</span><span class="p">(</span><span \
class="n">QByteArray</span><span class="p">(</span><span class="n">buffer</span><span \
class="p">,</span> <span class="mi">100</span><span class="p">));</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">292</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">name</span> <span class="o">=</span> <span class="n">QFile</span><span \
class="o">::</span><span class="n">decodeName</span><span class="p">(</span><span \
class="n">QByteArray</span><span class="p">(</span><span class="n">buffer</span><span \
class="p">,</span> <span class="n"><span class="hl">qstrnlen</span></span><span \
class="p"><span class="hl">(</span></span><span class="n"><span \
class="hl">buffer</span></span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="mi">100</span><span class="p">))<span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why \
can't we just use QFile::decodeName(const char * localFileName) overload?</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok, there \
is a limit of 100. then i suggest using QByteArray::fromRawData(buffer, \
qstrnlen(buffer, 100)) because qbytearray object is 100% temporary.</pre> <br />
<p>- Nick</p>
<br />
<p>On November 9th, 2015, 7:54 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2015, 7:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix KArchive for behavior change in Qt 5.6</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Embedded NULs are now preserved when converting from QByteArray to \
QString.</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">remove unused var \
(separate commit)</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">karchivetest passes again, with Qt 5.6 from git.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I complained about the behavior change on \
https://codereview.qt-project.org/106473</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/karchivetest.cpp <span style="color: \
grey">(d9662f5faadf9f08f71a386c0f9ecc8ef89af23a)</span></li>
<li>src/karchive.cpp <span style="color: \
grey">(e0a1eb2245767f9d605c44a6da481d290c2b15a5)</span></li>
<li>src/ktar.cpp <span style="color: \
grey">(824395e72e73b23f974614d5eff1fa58c7729dc0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126002/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2756754694925350363==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic