'Re: Review Request 124714: Add support to qmake's options to api.kde.org'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 124714: Add support to qmake's options to api.kde.org
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2015-11-08 18:35:05
Message-ID: 20151108183505.24343.33124 () mimi ! kde ! org
[Download RAW message or body]

--===============1620537807225527880==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124714/#review88165
-----------------------------------------------------------

Ship it!

Ship It!

- Alex Merry

On Nov. 8, 2015, 1:21 a.m., Lamarque Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124714/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2015, 1:21 a.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> NetworkManagerQt requires some options to be added to .pro file to compile:
> 
> QT += NetworkManagerQt dbus network
> CONFIG += link_pkgconfig
> PKGCONFIG += libnm # from NetworkManager package
> DEFINES += QT_NO_KEYWORDS # libnm declares a variable named signals
> 
> kapidox already supports the first option (QT), but not the others. This patch adds \
> support to adding the other three options. 
> 
> Diffs
> -----
> 
> src/kapidox/data/templates/fwinfo.html a20c1d1 
> 
> Diff: https://git.reviewboard.kde.org/r/124714/diff/
> 
> 
> Testing
> -------
> 
> I added the lines below to networkmanager-qt/metainfo.html and kapidox created the \
> correct output: 
> qmakepro:
> - CONFIG += link_pkgconfig
> - DEFINES += QT_NO_KEYWORDS
> - PKGCONFIG += libnm
> 
> 
> Thanks,
> 
> Lamarque Souza
> 
> 

--===============1620537807225527880==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124714/">https://git.reviewboard.kde.org/r/124714/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Alex Merry</p>

<br />
<p>On November 8th, 2015, 1:21 a.m. UTC, Lamarque Souza wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Lamarque Souza.</div>

<p style="color: grey;"><i>Updated Nov. 8, 2015, 1:21 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kapidox
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">NetworkManagerQt requires some options to be added to \
.pro file to compile:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">QT += NetworkManagerQt dbus network \
CONFIG += link_pkgconfig PKGCONFIG += libnm # from NetworkManager package
DEFINES += QT_NO_KEYWORDS # libnm declares a variable named signals</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kapidox already supports the first option (QT), but \
not the others. This patch adds support to adding the other three options.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I added the lines below to \
networkmanager-qt/metainfo.html and kapidox created the correct output:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
                inherit;">qmakepro:
 - CONFIG += link_pkgconfig
 - DEFINES += QT_NO_KEYWORDS
 - PKGCONFIG += libnm</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kapidox/data/templates/fwinfo.html <span style="color: \
grey">(a20c1d1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124714/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1620537807225527880==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 