From kde-frameworks-devel Sun Nov 08 10:37:15 2015 From: "Ralf Habacker" Date: Sun, 08 Nov 2015 10:37:15 +0000 To: kde-frameworks-devel Subject: Re: Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows im Message-Id: <20151108103715.24343.30956 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=144697905522284 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1178822616538540306==" --===============1178822616538540306== Content-Type: multipart/alternative; boundary="===============0017287674976310385==" --===============0017287674976310385== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121861/ ----------------------------------------------------------- (Updated Nov. 8, 2015, 10:37 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcoreaddons Description ------- Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher. Diffs ----- src/lib/CMakeLists.txt b2b46b164097f2394957f99ec4fb97b52f2bbc96 src/lib/io/kdirwatch.cpp 71f1892180b51cf65426696b4ffe918a02debba0 src/lib/io/kdirwatch_p.h 12839fdf4af5312eae3a636cec73f9dd2a41057d src/lib/io/kdirwatch_win.cpp 846e91ab1c932fbe1117ca6e3de3008f7f3a2130 Diff: https://git.reviewboard.kde.org/r/121861/diff/ Testing ------- File Attachments ---------------- KDE4 related patch https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/41da2dde-71f1-444c-8681-523aecb11edf__0001-Remove-obsolate-class-KFileSystemWatcher-which-is-ha.patch Thanks, Ralf Habacker --===============0017287674976310385== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121861/

This change has been marked as submitted.

Review request for KDE Frameworks.
By Ralf Habacker.

Updated Nov. 8, 2015, 10:37 a.m.

Repository: kcoreaddons

Description 

Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher.

Diffs

  • src/lib/CMakeLists.txt (b2b46b164097f2394957f99ec4fb97b52f2bbc96)
  • src/lib/io/kdirwatch.cpp (71f1892180b51cf65426696b4ffe918a02debba0)
  • src/lib/io/kdirwatch_p.h (12839fdf4af5312eae3a636cec73f9dd2a41057d)
  • src/lib/io/kdirwatch_win.cpp (846e91ab1c932fbe1117ca6e3de3008f7f3a2130)

View Diff

File Attachments

  • KDE4 related patch
    		•
    --===============0017287674976310385==-- --===============1178822616538540306== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============1178822616538540306==--