'Re: Review Request 125971: k7zip: fix memleaks, lower memory usage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 125971: k7zip: fix memleaks, lower memory usage
From:       "Nick Shaforostoff" <shafff () ukr ! net>
Date:       2015-11-07 10:07:07
Message-ID: 20151107100707.24343.91468 () mimi ! kde ! org
[Download RAW message or body]

--===============8661631359443250042==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125971/
-----------------------------------------------------------

(Updated Nov. 7, 2015, 10:07 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, David Faure and Laurent Montel.

Changes
-------

Submitted with commit 5e00ad1f31a6cb436f3d17896de82e1691acfefa by Nick Shaforostoff \
to branch master.

Repository: karchive

Description
-------

i couldn't find the place where the pointers contained in the member arrays are \
deleted so i have added their releasing. for this i have used qDeleteAll (you can \
search for qDeleteAll in the diff)

also i have reordered members of FileInfo to reduce its 'sizeof'
also using qvector for storing pointers is as fast as using qlist (or even faster) \
and needs less memory also i have switched qvector acces from operator[] to .at() \
because it is const (doesn't call detach() method internally) also i have disabled \
the code that was filling 'method' string because it was not used anywhere after

Diffs
-----

  src/k7zip.cpp 321620a 
  src/karchive.cpp 0ece37c 

Diff: https://git.reviewboard.kde.org/r/125971/diff/

Testing
-------

compiles fine

Thanks,

Nick Shaforostoff

--===============8661631359443250042==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125971/">https://git.reviewboard.kde.org/r/125971/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, David Faure and Laurent Montel.</div>
<div>By Nick Shaforostoff.</div>

<p style="color: grey;"><i>Updated Nov. 7, 2015, 10:07 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 5e00ad1f31a6cb436f3d17896de82e1691acfefa by Nick \
Shaforostoff to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">i couldn't find the place where the pointers contained \
in the member arrays are deleted so i have added their releasing. for this i have \
used qDeleteAll (you can search for qDeleteAll in the diff)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also \
i have reordered members of FileInfo to reduce its 'sizeof' also using qvector for \
storing pointers is as fast as using qlist (or even faster) and needs less memory \
also i have switched qvector acces from operator[] to .at() because it is const \
(doesn't call detach() method internally) also i have disabled the code that was \
filling 'method' string because it was not used anywhere after</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiles fine</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/k7zip.cpp <span style="color: grey">(321620a)</span></li>

 <li>src/karchive.cpp <span style="color: grey">(0ece37c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125971/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8661631359443250042==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 