[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125976: add an update() method
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-11-06 17:34:58
Message-ID: 20151106173458.24343.59920 () mimi ! kde ! org
[Download RAW message or body]
--===============6268825242826433852==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/#review88104
-----------------------------------------------------------
src/kpackage/private/packagejobthread.cpp (line 320)
<https://git.reviewboard.kde.org/r/125976/#comment60441>
QLatin1String("/metadata.desktop")
- Nick Shaforostoff
On Nov. 6, 2015, 4:10 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125976/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 4:10 p.m.)
>
>
> Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.
>
>
> Repository: kpackage
>
>
> Description
> -------
>
> new job based update() function that compared to install()
> if a package with the same pluginId is already installed,
> removes the old one before installing the new one, if
> and only if the version of the new one is more recent
>
>
> Diffs
> -----
>
> autotests/plasmoidpackagetest.h f730dce
> autotests/plasmoidpackagetest.cpp cccc567
> src/kpackage/CMakeLists.txt 3696f37
> src/kpackage/package.h 4ada8da
> src/kpackage/package.cpp 539b21a
> src/kpackage/packagestructure.h 9427b42
> src/kpackage/packagestructure.cpp 0070514
> src/kpackage/private/packagejob.cpp 0d2241b
> src/kpackage/private/packagejob_p.h 267429f
> src/kpackage/private/packagejobthread.cpp ca523b3
> src/kpackage/private/packagejobthread_p.h bf8a266
> src/kpackage/private/versionparser.cpp PRE-CREATION
> src/kpackagetool/CMakeLists.txt 78e0fb0
>
> Diff: https://git.reviewboard.kde.org/r/125976/diff/
>
>
> Testing
> -------
>
> covered by autotests
>
>
> Thanks,
>
> Marco Martin
>
>
--===============6268825242826433852==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125976/">https://git.reviewboard.kde.org/r/125976/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125976/diff/2/?file=415574#file415574line322" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kpackage/private/packagejobthread.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
PackageJobThread::installPackage(const QString &src, const QString \
&dest)</pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; ">bool PackageJobThread::installPackage(const QString &src, const \
QString &dest, bool update)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">322</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="nb">false</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">320</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">KPluginMetaData</span> <span class="n">oldMeta</span><span \
class="p">(</span><span class="n">targetName</span> <span class="o">+</span> <span \
class="s">"/metadata.desktop"</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QLatin1String("/metadata.desktop")</pre> </div>
</div>
<br />
<p>- Nick Shaforostoff</p>
<br />
<p>On November 6th, 2015, 4:10 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2015, 4:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">new job based update() function that compared to \
install() if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">covered by autotests</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/plasmoidpackagetest.h <span style="color: grey">(f730dce)</span></li>
<li>autotests/plasmoidpackagetest.cpp <span style="color: \
grey">(cccc567)</span></li>
<li>src/kpackage/CMakeLists.txt <span style="color: grey">(3696f37)</span></li>
<li>src/kpackage/package.h <span style="color: grey">(4ada8da)</span></li>
<li>src/kpackage/package.cpp <span style="color: grey">(539b21a)</span></li>
<li>src/kpackage/packagestructure.h <span style="color: grey">(9427b42)</span></li>
<li>src/kpackage/packagestructure.cpp <span style="color: \
grey">(0070514)</span></li>
<li>src/kpackage/private/packagejob.cpp <span style="color: \
grey">(0d2241b)</span></li>
<li>src/kpackage/private/packagejob_p.h <span style="color: \
grey">(267429f)</span></li>
<li>src/kpackage/private/packagejobthread.cpp <span style="color: \
grey">(ca523b3)</span></li>
<li>src/kpackage/private/packagejobthread_p.h <span style="color: \
grey">(bf8a266)</span></li>
<li>src/kpackage/private/versionparser.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/kpackagetool/CMakeLists.txt <span style="color: grey">(78e0fb0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125976/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6268825242826433852==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic