[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 125965: Add declarative plugin to KHolidays
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-11-06 14:29:15
Message-ID: 20151106142915.24343.25442 () mimi ! kde ! org
[Download RAW message or body]
--===============8710672899933148228==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125965/#review88099
-----------------------------------------------------------
src/declarative/holidayregionsmodel.cpp (line 81)
<https://git.reviewboard.kde.org/r/125965/#comment60440>
i suggest enclosing strings into QByteArrayLiteral.
see http://woboq.com/blog/qstringliteral.html for explanation and \
https://gitlab.com/pteam/pteam-qtbase/commit/05663e29d047851adb9a1ef440fb78b38ff3cc9b for the case when \
QBAL are not suitable
- Nick Shaforostoff
On Nov. 5, 2015, 7:57 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125965/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 7:57 p.m.)
>
>
> Review request for KDE Frameworks and John Layt.
>
>
> Repository: kholidays
>
>
> Description
> -------
>
> For now it contains just the model of holiday regions
> which will be used in the Plasma calendar events
> configuration.
>
>
> Diffs
> -----
>
> CMakeLists.txt e8b7970
> src/CMakeLists.txt c067b6c
> src/declarative/CMakeLists.txt PRE-CREATION
> src/declarative/holidayregionsmodel.h PRE-CREATION
> src/declarative/holidayregionsmodel.cpp PRE-CREATION
> src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION
> src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION
> src/declarative/qmldir PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125965/diff/
>
>
> Testing
> -------
>
> Applet configuration contains proper list of available
> holiday regions.
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============8710672899933148228==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125965/">https://git.reviewboard.kde.org/r/125965/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125965/diff/1/?file=415523#file415523line81" style="color: black; \
font-weight: bold; text-decoration: underline;">src/declarative/holidayregionsmodel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">81</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">roles</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">HolidayRegionsDeclarativeModel</span><span class="o">::</span><span \
class="n">DescriptionRole</span><span class="p">,</span> <span \
class="s">"description"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">i suggest enclosing strings into QByteArrayLiteral.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">see \
http://woboq.com/blog/qstringliteral.html for explanation and \
https://gitlab.com/pteam/pteam-qtbase/commit/05663e29d047851adb9a1ef440fb78b38ff3cc9b for the case when \
QBAL are not suitable</p></pre> </div>
</div>
<br />
<p>- Nick Shaforostoff</p>
<br />
<p>On November 5th, 2015, 7:57 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and John Layt.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2015, 7:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kholidays
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">For now it contains just the model of \
holiday regions which will be used in the Plasma calendar events
configuration.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Applet configuration contains proper list \
of available holiday regions.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e8b7970)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(c067b6c)</span></li>
<li>src/declarative/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/holidayregionsmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/holidayregionsmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/kholidaysdeclarativeplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/kholidaysdeclarativeplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125965/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8710672899933148228==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic