'Re: Review Request 125960: Fix build of some projects using ecm_create_qm_loader()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 125960: Fix build of some projects using ecm_create_qm_loader()
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2015-11-05 23:48:03
Message-ID: 20151105234803.24343.22301 () mimi ! kde ! org
[Download RAW message or body]

--===============3671561226600296557==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125960/#review88069
-----------------------------------------------------------

I'm confused about what you're trying to acheive with this. What you've actually \
done, as far as I can tell, is *stop* the files being set in the parent scope. That \
will make the project build, yes, but it will make ecm_create_qm_loader() essentially \
useless, because the file we generated won't be added to the target, and so won't be \
built.

Did you try running the unit tests? Because I'd be very surprised if they passed.

I suspect the issue analitza is having is similar to what I fixed in \
http://commits.kde.org/kconfig/19513e1910f19375a4c17a61f048c7f8c2f9e840 - using the \
file generation macro in a different CMakeLists.txt to the target the files are added \
to. Although I haven't looked at analitza's source code to be sure.

- Alex Merry

On Nov. 5, 2015, 2:36 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125960/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 2:36 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Makes sure the variable is properly initialized.
> 
> 
> Diffs
> -----
> 
> modules/ECMPoQmTools.cmake 22258dc 
> 
> Diff: https://git.reviewboard.kde.org/r/125960/diff/
> 
> 
> Testing
> -------
> 
> This error won't happen anymore:
> https://build.kde.org/job/analitza%20master%20kf5-qt5/12/PLATFORM=Linux,compiler=gcc/console
>  
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

--===============3671561226600296557==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125960/">https://git.reviewboard.kde.org/r/125960/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
confused about what you're trying to acheive with this. What you've actually done, as \
far as I can tell, is <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">stop</em> the files being set in the \
parent scope. That will make the project build, yes, but it will make \
ecm_create_qm_loader() essentially useless, because the file we generated won't be \
added to the target, and so won't be built.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Did you try running the \
unit tests? Because I'd be very surprised if they passed.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
suspect the issue analitza is having is similar to what I fixed in \
http://commits.kde.org/kconfig/19513e1910f19375a4c17a61f048c7f8c2f9e840 - using the \
file generation macro in a different CMakeLists.txt to the target the files are added \
to. Although I haven't looked at analitza's source code to be sure.</p></pre>  <br />

<p>- Alex Merry</p>

<br />
<p>On November 5th, 2015, 2:36 p.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules and KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Nov. 5, 2015, 2:36 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Makes sure the variable is properly \
initialized.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This error won't happen anymore: \
https://build.kde.org/job/analitza%20master%20kf5-qt5/12/PLATFORM=Linux,compiler=gcc/console</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMPoQmTools.cmake <span style="color: grey">(22258dc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125960/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3671561226600296557==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 