'Re: Review Request 125656: Drop empty files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 125656: Drop empty files
From:       "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date:       2015-10-21 15:10:56
Message-ID: 20151021151056.14267.69722 () mimi ! kde ! org
[Download RAW message or body]

--===============4938942141138267629==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125656/#review87212
-----------------------------------------------------------

Out of curiosity, why was it made only of commented functions? Is it something which \
was not working and meant to be fixed (but never done) long time ago?

- Luigi Toscano

On Oct. 21, 2015, 4:57 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125656/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 4:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Currently the file src/core/upload.cpp is under a LGPL-2 only license, and
> shipping the corresponding full license is required. Which is incompatible
> with the current frameworks policy. The mentioned file and the private header
> src/core/upload_p.h are currently "empty", as they contain only commented out
> functions. And these files are not part of the API, so it's safe to drop them.
> 
> 
> Diffs
> -----
> 
> src/core/upload.cpp 486129b55bb108f965050ecc25df7e6d98bebb9e 
> src/core/upload_p.h 4fa38689f64a0dec94666962a7541dd3d6086482 
> 
> Diff: https://git.reviewboard.kde.org/r/125656/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
> 

--===============4938942141138267629==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125656/">https://git.reviewboard.kde.org/r/125656/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Out \
of curiosity, why was it made only of commented functions? Is it something which was \
not working and meant to be fixed (but never done) long time ago?</p></pre>  <br />

<p>- Luigi Toscano</p>

<br />
<p>On October 21st, 2015, 4:57 p.m. CEST, Maximiliano Curia wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Jeremy Whiting.</div>
<div>By Maximiliano Curia.</div>

<p style="color: grey;"><i>Updated Oct. 21, 2015, 4:57 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently the file src/core/upload.cpp is under a \
LGPL-2 only license, and shipping the corresponding full license is required. Which \
is incompatible with the current frameworks policy. The mentioned file and the \
private header src/core/upload_p.h are currently "empty", as they contain only \
commented out functions. And these files are not part of the API, so it's safe to \
drop them.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/upload.cpp <span style="color: \
grey">(486129b55bb108f965050ecc25df7e6d98bebb9e)</span></li>

 <li>src/core/upload_p.h <span style="color: \
grey">(4fa38689f64a0dec94666962a7541dd3d6086482)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125656/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4938942141138267629==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 