[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().
From: "Allen Winter" <winter () kde ! org>
Date: 2015-10-20 20:39:50
Message-ID: 20151020203950.14267.36731 () mimi ! kde ! org
[Download RAW message or body]
--===============8717892979971176818==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 20, 2015, 2:13 p.m., Allen Winter wrote:
> > Does anyone object if I backport this to kdelibs KDE/4.14 ?
>
> Alex Merry wrote:
> I certainly don't, and Michael Pyne suggested above that he might do it himself.
done, backported to kdelibs KDE/4.14 branch with commit \
4f7ea2f770cf062ef22293fbb21a086f3e0cbfcb
- Allen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125711/#review87140
-----------------------------------------------------------
On Oct. 20, 2015, 8:33 a.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125711/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 8:33 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kparts
>
>
> Description
> -------
>
> When a part's main widget is destroyed, we should not delete the part
> immediately - both because deleting an object from inside one of its
> signals is not safe generally, and because derived classes may well hold
> QPointers to the widgets, expecting them to be cleared between the
> widget being destroyed and the part being destroyed.
>
>
> Diffs
> -----
>
> autotests/parttest.cpp c477face2f0f94f1d66deadedb4bc913eaa21842
> src/part.cpp 4a3150e8aa2a6ed2aff68c945135b3536db2059d
>
> Diff: https://git.reviewboard.kde.org/r/125711/diff/
>
>
> Testing
> -------
>
> Unit tests for KParts pass.
>
> Running akregator under valgrind no longer produces a bunch of "invalid reads" from \
> KHTMLPart when switching around between articles.
>
> Thanks,
>
> Alex Merry
>
>
--===============8717892979971176818==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125711/">https://git.reviewboard.kde.org/r/125711/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 20th, 2015, 2:13 p.m. UTC, <b>Allen \
Winter</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Does anyone object if I backport this to kdelibs \
KDE/4.14 ?</p></pre> </blockquote>
<p>On October 20th, 2015, 5:25 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
certainly don't, and Michael Pyne suggested above that he might do it \
himself.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">done, \
backported to kdelibs KDE/4.14 branch with commit \
4f7ea2f770cf062ef22293fbb21a086f3e0cbfcb</p></pre> <br />
<p>- Allen</p>
<br />
<p>On October 20th, 2015, 8:33 a.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2015, 8:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kparts
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When a part's main widget is destroyed, we should not delete the \
part immediately - both because deleting an object from inside one of its
signals is not safe generally, and because derived classes may well hold
QPointers to the widgets, expecting them to be cleared between the
widget being destroyed and the part being destroyed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Unit tests for KParts pass.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Running akregator under valgrind no longer produces a bunch of "invalid \
reads" from KHTMLPart when switching around between articles.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/parttest.cpp <span style="color: \
grey">(c477face2f0f94f1d66deadedb4bc913eaa21842)</span></li>
<li>src/part.cpp <span style="color: \
grey">(4a3150e8aa2a6ed2aff68c945135b3536db2059d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125711/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8717892979971176818==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic