'Re: Review Request 124134: Fixing KDED string references'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 124134: Fixing KDED string references
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2015-10-11 17:03:47
Message-ID: 20151011170347.23606.4499 () mimi ! kde ! org
[Download RAW message or body]

--===============6368770253639675573==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124134/
-----------------------------------------------------------

(Updated Oct. 11, 2015, 5:03 p.m.)

Status
------

This change has been discarded.

Review request for KDE Frameworks.

Repository: kio

Description
-------

Changed to kded5.

Diffs
-----

  src/kcms/kio/kcookiesmain.cpp c4e36ac69e64f0540167e2a68cd8dadde4333450 
  src/kcms/kio/kcookiesmanagement.cpp c041fc2f2e1a162ced43c944baeec1784e0bcca9 
  src/kcms/kio/kcookiespolicies.cpp 7470616a130decb4261698aa4d4dc3da5c68ec22 
  src/kcms/kio/ksaveioconfig.cpp 82ca6d9c90a58190d912f0f0c791c5e229254ec6 

Diff: https://git.reviewboard.kde.org/r/124134/diff/

Testing
-------

Notice that I was only able to test this with the 5.10 tag since I don't have the \
rest of the 5.11 frameworks.

Before this patch, if you made sure kded4 was not running and you tried 

$ kcmshell5 cookies

a message would pop up saying the cookies service was not available. After this patch \
you are able to view and edit your cookies. After this patch I also have \
~/.config/kcookiejarrc.

Thanks,

David Narváez

--===============6368770253639675573==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124134/">https://git.reviewboard.kde.org/r/124134/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated Oct. 11, 2015, 5:03 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Changed to kded5.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Notice that I was only able to test this with the 5.10 \
tag since I don't have the rest of the 5.11 frameworks.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Before this patch, if you made sure kded4 was not running and you tried \
</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">$ kcmshell5 cookies</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">a \
message would pop up saying the cookies service was not available. After this patch \
you are able to view and edit your cookies. After this patch I also have \
~/.config/kcookiejarrc.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kcms/kio/kcookiesmain.cpp <span style="color: \
grey">(c4e36ac69e64f0540167e2a68cd8dadde4333450)</span></li>

 <li>src/kcms/kio/kcookiesmanagement.cpp <span style="color: \
grey">(c041fc2f2e1a162ced43c944baeec1784e0bcca9)</span></li>

 <li>src/kcms/kio/kcookiespolicies.cpp <span style="color: \
grey">(7470616a130decb4261698aa4d4dc3da5c68ec22)</span></li>

 <li>src/kcms/kio/ksaveioconfig.cpp <span style="color: \
grey">(82ca6d9c90a58190d912f0f0c791c5e229254ec6)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124134/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6368770253639675573==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 