--===============1009721306360225299== Content-Type: multipart/alternative; boundary=001a11c262bce4930805218b1af9 --001a11c262bce4930805218b1af9 Content-Type: text/plain; charset=UTF-8 Am 07.10.2015 22:25 schrieb "Albert Astals Cid" : > > El Tuesday 06 October 2015, a les 19:20:00, Frank Reininghaus va escriure: > > Hi, > > > > 2015-10-06 15:04 GMT+02:00 : > > > GENERAL INFO > > > > > > BUILD UNSTABLE > > > Build URL: > > > https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler= > > > gcc/119/ Project: PLATFORM=Linux,compiler=gcc > > > Date of build: Tue, 06 Oct 2015 12:34:13 +0000 > > > Build duration: 14 min > > > > > > CHANGE SET > > > Revision 4f464d4ade465ad009758d12908f72189953c4f1 by scripty: (SVN_SILENT > > > made messages (.desktop file) - always resolve ours)> > > > change: edit src/new_file_templates/TextFile.desktop > > > change: edit src/widgets/konqpopupmenuplugin.desktop > > > change: edit src/new_file_templates/linkProgram.desktop > > > change: edit src/new_file_templates/linkPath.desktop > > > change: edit src/new_file_templates/linkURL.desktop > > > change: edit src/new_file_templates/Directory.desktop > > > change: edit src/new_file_templates/HTMLFile.desktop > > > > > > JUNIT RESULTS > > > > > > Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), > > > Total: 46 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutest > > it looks like this test failure has something to do with my recent > > commit that added the "new file" templates. I cannot reproduce it > > locally though. The log at > > > > https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc > > /119/testReport/%28root%29/TestSuite/kiofilewidgets_knewfilemenutest/ > > > > indicates that the test tries to use klauncher, which is not running > > on the server. klauncher is part of kinit, which is apparently not a > > dependency of kio, maybe this is the problem? > > > > The last successful executions of the test simply skipped it, see, e.g., > > > > https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc > > /117/testReport/%28root%29/TestSuite/kiofilewidgets_knewfilemenutest/ > > > > At first sight, it looks to me like the test might be broken because > > it relies on stuff that kio does not officially depend on. It was just > > not noticed before because KNewFileMenu did not work at all because of > > the missing templates, such that the test was skipped. > > > > Does anyone see a good way to fix this without disabling the test? > > So what depends on klauncher the test or knewfilemenu? I'm not quite sure (cannot check right now because I'm travelling without my laptop and analyzing code on the phone screen is a bit tedious). Thanks for bringing up the question - in frameworks, we should really make sure that not only build time dependencies, but also run time dependencies are handled correctly. Cheers, Frank --001a11c262bce4930805218b1af9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Am 07.10.2015 22:25 schrieb "Albert Astals Cid" <aacid@kde.org>:
>
> El Tuesday 06 October 2015, a les 19:20:00, Frank Reininghaus va escri= ure:
> > Hi,
> >
> > 2015-10-06 15:04 GMT+02:00=C2=A0 <no-reply@kde.org>:
> > > GENERAL INFO
> > >
> > > BUILD UNSTABLE
> > > Build URL:
> > > https://build.kde.org/job/kio%20master%20kf5-= qt5/PLATFORM=3DLinux,compiler=3D
> > > gcc/119/ Project: PLATFORM=3DLinux,compiler=3Dgcc
> > > Date of build: Tue, 06 Oct 2015 12:34:13 +0000
> > > Build duration: 14 min
> > >
> > > CHANGE SET
> > > Revision 4f464d4ade465ad009758d12908f72189953c4f1 by scripty= : (SVN_SILENT
> > > made messages (.desktop file) - always resolve ours)>
> > >=C2=A0 =C2=A0change: edit src/new_file_templates/TextFile.des= ktop
> > >=C2=A0 =C2=A0change: edit src/widgets/konqpopupmenuplugin.des= ktop
> > >=C2=A0 =C2=A0change: edit src/new_file_templates/linkProgram.= desktop
> > >=C2=A0 =C2=A0change: edit src/new_file_templates/linkPath.des= ktop
> > >=C2=A0 =C2=A0change: edit src/new_file_templates/linkURL.desk= top
> > >=C2=A0 =C2=A0change: edit src/new_file_templates/Directory.de= sktop
> > >=C2=A0 =C2=A0change: edit src/new_file_templates/HTMLFile.des= ktop
> > >
> > > JUNIT RESULTS
> > >
> > > Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped:= 0 test(s),
> > > Total: 46 test(s)Failed: TestSuite.kiofilewidgets-knewfileme= nutest
> > it looks like this test failure has something to do with my recen= t
> > commit that added the "new file" templates. I cannot re= produce it
> > locally though. The log at
> >
> > https://build.kde.org/job/kio%20master%20kf5-qt= 5/PLATFORM=3DLinux,compiler=3Dgcc
> > /119/testReport/%28root%29/TestSuite/kiofilewidgets_knewfilemenut= est/
> >
> > indicates that the test tries to use klauncher, which is not runn= ing
> > on the server. klauncher is part of kinit, which is apparently no= t a
> > dependency of kio, maybe this is the problem?
> >
> > The last successful executions of the test simply skipped it, see= , e.g.,
> >
> > https://build.kde.org/job/kio%20master%20kf5-qt= 5/PLATFORM=3DLinux,compiler=3Dgcc
> > /117/testReport/%28root%29/TestSuite/kiofilewidgets_knewfilemenut= est/
> >
> > At first sight, it looks to me like the test might be broken beca= use
> > it relies on stuff that kio does not officially depend on. It was= just
> > not noticed before because KNewFileMenu did not work at all becau= se of
> > the missing templates, such that the test was skipped.
> >
> > Does anyone see a good way to fix this without disabling the test= ?
>
> So what depends on klauncher the test or knewfilemenu?

I'm not quite sure (cannot check right now because I'= ;m travelling without my laptop and analyzing code on the phone screen is a= bit tedious). Thanks for bringing up the question - in frameworks,=C2=A0 w= e should really make sure that not only build time dependencies, but also r= un time dependencies are handled correctly.

Cheers,
Frank

--001a11c262bce4930805218b1af9-- --===============1009721306360225299== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============1009721306360225299==--