[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 125425: Add the desktop file that is required for adding services to the context
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2015-10-03 12:13:10
Message-ID: 20151003121310.27965.14435 () mimi ! kde ! org
[Download RAW message or body]
--===============2334978211420711269==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 3, 2015, 10:08 a.m., David Faure wrote:
> > I just realized another problem with this approach: since the latest libkonq \
> > release installs konqpopupmenuplugin.desktop already, this patch will make the \
> > next KIO release conflict with that last libkonq release (which by definition \
> > cannot have a version check). Moving stuff between products is hard!
> > So you were right, better install this under a different filename like in your v1 \
> > of the patch (just doublecheck that having two definitions of the same \
> > servicetype in two different files doesn't break things, but I don't think it \
> > does). And in the second step (later) we can reuse that filename to provide a \
> > different servicetypename and deprecate KonqPopupMenuPlugin. Sorry for not \
> > realizing this sooner.
> > In any case, due to the issue with translations we wanted to commit this after \
> > today's release (but of course this delays the fix by one month). Unless Luigi is \
> > available this weekend to do the merging, but it's getting tight.
>
> Luigi Toscano wrote:
> I would say that it's better to postpone for the next release (merge immediately \
> after the tag), so there is a bit more time to catch issues and it's not risky for \
> this release (too tight now, exactly).
> since the latest libkonq release installs konqpopupmenuplugin.desktop already
But that release is kdelibs4 based, so there shouldn't be any conflict here...
- Hrvoje
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125425/#review86276
-----------------------------------------------------------
On Oct. 3, 2015, 9:50 a.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125425/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 9:50 a.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Bugs: 350769
> https://bugs.kde.org/show_bug.cgi?id=350769
>
>
> Repository: kio
>
>
> Description
> -------
>
> This is a modified version of the file konqpopupmenuplugin.desktop in kde-baseapps \
> (see https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b \
> 20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop \
> for the latest version).
> I modified the name to kioservicemenuplugin.desktop because the file has not been \
> Konqueror-specific for quite some time. I also updated the 'Comment' accordingly \
> and removed the outdated translations.
> I hope I did that right - any comments are welcome!
>
> Note: Just like https://git.reviewboard.kde.org/r/124983/ this should probably be \
> pushed to master after the tagging for the next version because of the \
> translations. On the one hand, the translation of this 'Comment' might not be that \
> important because the it is not shown anywhere in the UI as far as I know (it is \
> shown in the 'Type' column in Dolphin though when viewing the directory where this \
> file is installed). But on the other hand, it might be better to resolve both \
> context menu issues in the same KIO release. What do others think?
>
> Diffs
> -----
>
> src/widgets/CMakeLists.txt 820cd34
> src/widgets/konqpopupmenuplugin.desktop PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125425/diff/
>
>
> Testing
> -------
>
> Konsole service actions are shown in the context menu again.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
--===============2334978211420711269==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125425/">https://git.reviewboard.kde.org/r/125425/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 3rd, 2015, 10:08 a.m. CEST, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I just realized another problem with this approach: \
since the latest libkonq release installs konqpopupmenuplugin.desktop already, this \
patch will make the next KIO release conflict with that last libkonq release (which \
by definition cannot have a version check). Moving stuff between products is \
hard!</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So you were right, better install this under a \
different filename like in your v1 of the patch (just doublecheck that having two \
definitions of the same servicetype in two different files doesn't break things, but \
I don't think it does). And in the second step (later) we can reuse that filename to \
provide a different servicetypename and deprecate KonqPopupMenuPlugin. Sorry for not \
realizing this sooner.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">In any case, due to the issue with \
translations we wanted to commit this after today's release (but of course this \
delays the fix by one month). Unless Luigi is available this weekend to do the \
merging, but it's getting tight.</p></pre> </blockquote>
<p>On October 3rd, 2015, 2 p.m. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would say that it's better to postpone for the next release (merge immediately after \
the tag), so there is a bit more time to catch issues and it's not risky for this \
release (too tight now, exactly).</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">since the latest libkonq release installs konqpopupmenuplugin.desktop \
already</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">But that release is kdelibs4 based, so there shouldn't \
be any conflict here...</p></pre> <br />
<p>- Hrvoje</p>
<br />
<p>On October 3rd, 2015, 9:50 a.m. CEST, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2015, 9:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=350769">350769</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a modified version of the file \
konqpopupmenuplugin.desktop in kde-baseapps (see \
https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2 \
b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop \
for the latest version).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I modified the name to \
kioservicemenuplugin.desktop because the file has not been Konqueror-specific for \
quite some time. I also updated the 'Comment' accordingly and removed the outdated \
translations.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I hope I did that right - any comments are \
welcome!</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Note: Just like \
https://git.reviewboard.kde.org/r/124983/ this should probably be pushed to master \
after the tagging for the next version because of the translations. On the one hand, \
the translation of this 'Comment' might not be that important because the it is not \
shown anywhere in the UI as far as I know (it is shown in the 'Type' column in \
Dolphin though when viewing the directory where this file is installed). But on the \
other hand, it might be better to resolve both context menu issues in the same KIO \
release. What do others think?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Konsole service actions are shown in the context menu \
again.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/CMakeLists.txt <span style="color: grey">(820cd34)</span></li>
<li>src/widgets/konqpopupmenuplugin.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125425/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2334978211420711269==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic