[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)
From: "Sune Vuorela" <kde () pusling ! com>
Date: 2015-09-28 18:25:59
Message-ID: 20150928182559.8863.13263 () mimi ! kde ! org
[Download RAW message or body]
--===============8643329248351044961==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125436/#review86063
-----------------------------------------------------------
src/widgets/koverlayiconplugin.h (line 55)
<https://git.reviewboard.kde.org/r/125436/#comment59376>
Is a plugin expected to return multiple overlays, and if so are consumers of this \
interface expected to stack them all together? In what order?
How is multiple oevrlay plugins to be handled? all of them stacked together ? In \
what order?
I am wondering if either a QList<QIcon> - or let the plugin do the squashing - \
just QIcon - is a better return value.
the naming "getOverlays" feels a bit java-esque.
oh. and should it be const?
I think I like the concept, and it feels like kio is the right home for it.
- Sune Vuorela
On Sept. 28, 2015, 9:14 a.m., Olivier Goffart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125436/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 9:14 a.m.)
>
>
> Review request for Dolphin and KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> The interface from https://git.reviewboard.kde.org/r/125136/ moved into KIO.
>
>
> Diffs
> -----
>
> src/widgets/CMakeLists.txt 820cd34
> src/widgets/koverlayiconplugin.cpp PRE-CREATION
> src/widgets/koverlayiconplugin.desktop PRE-CREATION
> src/widgets/koverlayiconplugin.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125436/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Olivier Goffart
>
>
--===============8643329248351044961==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125436/">https://git.reviewboard.kde.org/r/125436/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125436/diff/2/?file=408602#file408602line55" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/widgets/koverlayiconplugin.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">55</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">virtual</span> <span class="n">QStringList</span> <span \
class="n">getOverlays</span><span class="p">(</span><span class="k">const</span> \
<span class="n">QUrl</span> <span class="o">&</span><span \
class="n">item</span><span class="p">)</span> <span class="o">=</span> <span \
class="mi">0</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is a \
plugin expected to return multiple overlays, and if so are consumers of this \
interface expected to stack them all together? In what order?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How \
is multiple oevrlay plugins to be handled? all of them stacked together ? In what \
order?</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I am wondering if either a QList<QIcon> - or let \
the plugin do the squashing - just QIcon - is a better return value.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">the naming "getOverlays" feels a bit java-esque. oh. and should it be \
const?</p></pre> </div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think I like the concept, and it feels like kio is the right home for it.</p></pre>
<p>- Sune Vuorela</p>
<br />
<p>On September 28th, 2015, 9:14 a.m. UTC, Olivier Goffart wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and KDE Frameworks.</div>
<div>By Olivier Goffart.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2015, 9:14 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The interface from \
https://git.reviewboard.kde.org/r/125136/ moved into KIO.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/CMakeLists.txt <span style="color: grey">(820cd34)</span></li>
<li>src/widgets/koverlayiconplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/widgets/koverlayiconplugin.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/widgets/koverlayiconplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125436/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8643329248351044961==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic