[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 124788: Replace std::auto_ptr with std::unique_ptr
From: "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date: 2015-09-22 9:54:19
Message-ID: 20150922095419.14939.6915 () mimi ! kde ! org
[Download RAW message or body]
--===============1374041948010475679==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124788/#review85738
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Tobias Holmedahl Sandsmark
On Sept. 22, 2015, 8:25 a.m., Armin K. wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124788/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 8:25 a.m.)
>
>
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: khtml
>
>
> Description
> -------
>
> std::auto_ptr is deprecated and this patch silences a number of compiler warnings \
> when using GCC-5.x.
> Other frameworks use std::unique_ptr too and no public headers were changed in the \
> process.
>
> Diffs
> -----
>
> src/svg/SVGDocumentExtensions.h 71ad134
> src/svg/SVGDocumentExtensions.cpp 935fb20
> src/svg/SVGElement.cpp 2d2e4b3
> src/svg/SVGMaskElement.h 850df29
> src/svg/SVGMaskElement.cpp e6039d7
> src/svg/SVGPatternElement.cpp 5773b9f
> src/svg/graphics/SVGPaintServerPattern.h 5ba655f
> src/svg/graphics/SVGPaintServerPattern.cpp 7fcd4f3
>
> Diff: https://git.reviewboard.kde.org/r/124788/diff/
>
>
> Testing
> -------
>
> It builds!
>
>
> Thanks,
>
> Armin K.
>
>
--===============1374041948010475679==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124788/">https://git.reviewboard.kde.org/r/124788/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Martin Tobias Holmedahl Sandsmark</p>
<br />
<p>On September 22nd, 2015, 8:25 a.m. UTC, Armin K. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Armin K..</div>
<p style="color: grey;"><i>Updated Sept. 22, 2015, 8:25 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">std::auto_ptr is deprecated and this patch silences a \
number of compiler warnings when using GCC-5.x.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other \
frameworks use std::unique_ptr too and no public headers were changed in the \
process.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It builds!</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/svg/SVGDocumentExtensions.h <span style="color: grey">(71ad134)</span></li>
<li>src/svg/SVGDocumentExtensions.cpp <span style="color: \
grey">(935fb20)</span></li>
<li>src/svg/SVGElement.cpp <span style="color: grey">(2d2e4b3)</span></li>
<li>src/svg/SVGMaskElement.h <span style="color: grey">(850df29)</span></li>
<li>src/svg/SVGMaskElement.cpp <span style="color: grey">(e6039d7)</span></li>
<li>src/svg/SVGPatternElement.cpp <span style="color: grey">(5773b9f)</span></li>
<li>src/svg/graphics/SVGPaintServerPattern.h <span style="color: \
grey">(5ba655f)</span></li>
<li>src/svg/graphics/SVGPaintServerPattern.cpp <span style="color: \
grey">(7fcd4f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124788/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1374041948010475679==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic