[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 125318: KBuildSycocaProgressDialog: use Qt's builtin busy indicator.
From: "Sune Vuorela" <kde () pusling ! com>
Date: 2015-09-20 10:10:44
Message-ID: 20150920101044.14939.8146 () mimi ! kde ! org
[Download RAW message or body]
--===============5657379068690008520==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125318/#review85681
-----------------------------------------------------------
If we can't determine the time, then yes, let's use the 'infinite spinner' instead of \
fake calculations.
I'm not sure I'm enough into the kservice code to actually give a shipit, so I'll \
refrain from that.
- Sune Vuorela
On Sept. 19, 2015, 10:58 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125318/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 10:58 p.m.)
>
>
> Review request for KDE Frameworks and Albert Astals Cid.
>
>
> Repository: kio
>
>
> Description
> -------
>
> This makes the code much simpler and looks better to the user
> than a fake progress.
>
> Also removed the 1s delay before closing the dialog.
> Users like fast, not slow ;)
>
> BUG: 158672
> Change-Id: I4a5cc975239d5c2998cdc3079890834c23ae677d
> REVIEW: 125318
> FIXED-IN: 5.15
>
>
> Diffs
> -----
>
> src/widgets/kbuildsycocaprogressdialog.h 88c5087990c01725e065fc650e63de246b3032e1
> src/widgets/kbuildsycocaprogressdialog.cpp 78d23dfda174f195e4c7fdfc1e128e83194326f3 \
>
> Diff: https://git.reviewboard.kde.org/r/125318/diff/
>
>
> Testing
> -------
>
> kio/tests/ksycocaupdatetest, after deleting ksycoca so that it doesn't end too fast \
> ;)
>
> Thanks,
>
> David Faure
>
>
--===============5657379068690008520==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125318/">https://git.reviewboard.kde.org/r/125318/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If we \
can't determine the time, then yes, let's use the 'infinite spinner' instead of fake \
calculations.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm not sure I'm enough into the kservice code to \
actually give a shipit, so I'll refrain from that.</p></pre> <br />
<p>- Sune Vuorela</p>
<br />
<p>On September 19th, 2015, 10:58 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2015, 10:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This makes the code much simpler and looks better to the user than a \
fake progress.
Also removed the 1s delay before closing the dialog.
Users like fast, not slow ;)
BUG: 158672
Change-Id: I4a5cc975239d5c2998cdc3079890834c23ae677d
REVIEW: 125318
FIXED-IN: 5.15</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kio/tests/ksycocaupdatetest, after deleting ksycoca so \
that it doesn't end too fast ;)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/kbuildsycocaprogressdialog.h <span style="color: \
grey">(88c5087990c01725e065fc650e63de246b3032e1)</span></li>
<li>src/widgets/kbuildsycocaprogressdialog.cpp <span style="color: \
grey">(78d23dfda174f195e4c7fdfc1e128e83194326f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125318/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5657379068690008520==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic