'Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()
From:       "Alex Richardson" <arichardson.kde () gmail ! com>
Date:       2015-09-08 19:28:31
Message-ID: 20150908192831.24667.84744 () mimi ! kde ! org
[Download RAW message or body]

--===============8489570902204279624==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125048/
-----------------------------------------------------------

(Updated Sept. 8, 2015, 7:28 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and David Faure.

Changes
-------

Submitted with commit 6db255388532a4fd0788aa971c83798e1849d479 by Alex Richardson to \
branch master.

Repository: kio

Description
-------

Use JSON files directly instead of kcoreaddons_desktop_to_json()

Diffs
-----

  src/ioslaves/http/kcookiejar/CMakeLists.txt \
7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365   \
src/ioslaves/http/kcookiejar/kcookiejar.desktop \
3ea56abdc134cae22b69d7b7636ce6dd415a3d9b   \
src/ioslaves/http/kcookiejar/kcookiejar.json PRE-CREATION   src/kpac/CMakeLists.txt \
fc5989714480ca49b5bd72e1c7b458b26bd0d9bc   src/kpac/proxyscout.desktop \
a545f3d6ef2fd18b1a2c85ebff15c9f2513d87f1   src/kpac/proxyscout.json PRE-CREATION 
  src/kpasswdserver/CMakeLists.txt 11c30201012fbe413ff58561b54255e88c2c55b9 
  src/kpasswdserver/kpasswdserver.desktop bc788e5665e3d9d43309da241c3a3f5ac3cd0fc9 
  src/kpasswdserver/kpasswdserver.json PRE-CREATION 
  src/kssld/CMakeLists.txt bf6970c2741a6edd01e36b86744d643e70046889 
  src/kssld/kssld.desktop 86581b208ffc89fa5235f9284395d9d7ccebc472 
  src/kssld/kssld.json PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125048/diff/

Testing
-------

Thanks,

Alex Richardson

--===============8489570902204279624==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125048/">https://git.reviewboard.kde.org/r/125048/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Richardson.</div>

<p style="color: grey;"><i>Updated Sept. 8, 2015, 7:28 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 6db255388532a4fd0788aa971c83798e1849d479 by Alex \
Richardson to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use JSON files directly instead of kcoreaddons_desktop_to_json()</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: \
grey">(7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365)</span></li>

 <li>src/ioslaves/http/kcookiejar/kcookiejar.desktop <span style="color: \
grey">(3ea56abdc134cae22b69d7b7636ce6dd415a3d9b)</span></li>

 <li>src/ioslaves/http/kcookiejar/kcookiejar.json <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kpac/CMakeLists.txt <span style="color: \
grey">(fc5989714480ca49b5bd72e1c7b458b26bd0d9bc)</span></li>

 <li>src/kpac/proxyscout.desktop <span style="color: \
grey">(a545f3d6ef2fd18b1a2c85ebff15c9f2513d87f1)</span></li>

 <li>src/kpac/proxyscout.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/kpasswdserver/CMakeLists.txt <span style="color: \
grey">(11c30201012fbe413ff58561b54255e88c2c55b9)</span></li>

 <li>src/kpasswdserver/kpasswdserver.desktop <span style="color: \
grey">(bc788e5665e3d9d43309da241c3a3f5ac3cd0fc9)</span></li>

 <li>src/kpasswdserver/kpasswdserver.json <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kssld/CMakeLists.txt <span style="color: \
grey">(bf6970c2741a6edd01e36b86744d643e70046889)</span></li>

 <li>src/kssld/kssld.desktop <span style="color: \
grey">(86581b208ffc89fa5235f9284395d9d7ccebc472)</span></li>

 <li>src/kssld/kssld.json <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125048/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8489570902204279624==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 