'Re: Review Request 124963: New widget: KNewPasswordWidget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 124963: New widget: KNewPasswordWidget
From:       "Sune Vuorela" <kde () pusling ! com>
Date:       2015-08-29 20:49:11
Message-ID: 20150829204911.4103.52577 () mimi ! kde ! org
[Download RAW message or body]

--===============3444383208386577455==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote:
> > src/knewpasswordwidget.cpp, line 75
> > <https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line75>
> > 
> > i18n instead of tr
> 
> Sune Vuorela wrote:
> Aren't we in a tier1 framework where i18n and friends aren't available?
> 
> Lamarque Souza wrote:
> Yeah, you're right. Please revert the i18n change and sorry for not noticing that \
> before. 
> Martin Klapetek wrote:
> Fwiw, kwidgetsaddons has i18n usage already.

Not in 77e030112909e218aa85f851b289d298dc68a9f2 at least. There is some examples that \
promotes usage of i18n, but none of the actual code uses it.

- Sune

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124963/#review84525
-----------------------------------------------------------

On Aug. 28, 2015, 3:52 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124963/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 3:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> This widget is a stripped-down version of KNewPasswordDialog, without any \
> dialog-specific stuff. 
> ### Why a new widget?
> 
> This widget is meant to be easily embedded in any custom password dialog, including \
> KNewPasswordDialog. It's the least common denominator of features that any password \
> dialog should offer to the user. 
> ### Features
> 
> * Password visibility action (same as RR 124698). The password verification field \
>                 is hidden if the user shows the password.
> * Background warning colour. The password verification field gets a coloured \
> background whenever the password and its verification don't match. (feature \
>                 borrowed from Keepass)
> * Password status signal. This allows the upper level dialogs to update their stuff \
>                 (enable/disable OK button, show warnings for low password strength, \
>                 etc.)
> * Password strength bar can be hidden.
> * Unit test.
> 
> ### Use cases
> At least the following:
> 
> * Ark (new archive dialog)
> * KNewPasswordDialog refactoring (my next RR if this one gets accepted)
> 
> 
> Diffs
> -----
> 
> autotests/CMakeLists.txt ac708ef33e3be89db85d43911f96e536c52f741d 
> autotests/knewpasswordwidgettest.h PRE-CREATION 
> autotests/knewpasswordwidgettest.cpp PRE-CREATION 
> src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
> src/knewpasswordwidget.h PRE-CREATION 
> src/knewpasswordwidget.cpp PRE-CREATION 
> src/knewpasswordwidget.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124963/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> knewpasswordwidget1.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/5796469c-28b7-4151-b9cb-6a327631db75__knewpasswordwidget1.png
>  knewpasswordwidget2.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/b3bfc9ac-ab8e-404c-8091-b5ad9e3e054f__knewpasswordwidget2.png
>  knewpasswordwidget3.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/dfaeea4e-65da-4961-b266-986a21f54ca7__knewpasswordwidget3.png
>  
> 
> Thanks,
> 
> Elvis Angelaccio
> 
> 

--===============3444383208386577455==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124963/">https://git.reviewboard.kde.org/r/124963/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 28th, 2015, 11:30 a.m. UTC, <b>Lamarque \
Souza</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line75" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/knewpasswordwidget.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">75</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">toggleEchoModeAction</span><span class="o">-&gt;</span><span \
class="n">setToolTip</span><span class="p">(</span><span class="n">tr</span><span \
class="p">(</span><span class="s">&quot;Change the visibility of the \
password&quot;</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i18n \
instead of tr</p></pre>  </blockquote>

 <p>On August 29th, 2015, 4:21 p.m. UTC, <b>Sune Vuorela</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Aren't we in a tier1 framework where i18n and friends aren't \
available?</p></pre>  </blockquote>

 <p>On August 29th, 2015, 8:07 p.m. UTC, <b>Lamarque Souza</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah, \
you're right. Please revert the i18n change and sorry for not noticing that \
before.</p></pre>  </blockquote>

 <p>On August 29th, 2015, 8:14 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fwiw, \
kwidgetsaddons has i18n usage already.</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Not in 77e030112909e218aa85f851b289d298dc68a9f2 at least. There is some \
examples that promotes usage of i18n, but none of the actual code uses it.</p></pre> \
<br />

<p>- Sune</p>

<br />
<p>On August 28th, 2015, 3:52 p.m. UTC, Elvis Angelaccio wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Elvis Angelaccio.</div>

<p style="color: grey;"><i>Updated Aug. 28, 2015, 3:52 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This widget is a stripped-down version of \
KNewPasswordDialog, without any dialog-specific stuff.</p> <h3 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Why a new widget?</h3> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This widget is meant to be easily \
embedded in any custom password dialog, including KNewPasswordDialog. It's the least \
common denominator of features that any password dialog should offer to the user.</p> \
<h3 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">Features</h3> <ul style="padding: \
0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Password visibility action (same as RR 124698). The \
password verification field is hidden if the user shows the password.</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Background warning colour. The password verification field gets a coloured \
background whenever the password and its verification don't match. (feature borrowed \
from Keepass)</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Password status signal. This allows the \
upper level dialogs to update their stuff (enable/disable OK button, show warnings \
for low password strength, etc.)</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Password strength bar \
can be hidden.</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Unit test.</li> </ul>
<h3 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">Use cases</h3> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At \
least the following:</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Ark (new archive \
dialog)</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">KNewPasswordDialog refactoring (my next RR if this one \
gets accepted)</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: \
grey">(ac708ef33e3be89db85d43911f96e536c52f741d)</span></li>

 <li>autotests/knewpasswordwidgettest.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/knewpasswordwidgettest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/CMakeLists.txt <span style="color: \
grey">(e03e9bbd6d73811873b0a465f86da269f4295138)</span></li>

 <li>src/knewpasswordwidget.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/knewpasswordwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/knewpasswordwidget.ui <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124963/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/5796469c \
-28b7-4151-b9cb-6a327631db75__knewpasswordwidget1.png">knewpasswordwidget1.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/b3bfc9ac \
-ab8e-404c-8091-b5ad9e3e054f__knewpasswordwidget2.png">knewpasswordwidget2.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/dfaeea4e \
-65da-4961-b266-986a21f54ca7__knewpasswordwidget3.png">knewpasswordwidget3.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3444383208386577455==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 