'Re: Review Request 124105: Adhere a bit better to the spec'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 124105: Adhere a bit better to the spec
From:       "Sune Vuorela" <kde () pusling ! com>
Date:       2015-08-16 13:14:36
Message-ID: 20150816131436.3671.81199 () mimi ! kde ! org
[Download RAW message or body]

--===============0284038314309702895==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124105/
-----------------------------------------------------------

(Updated Aug. 16, 2015, 1:14 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, Aleix Pol Gonzalez, Christoph Feck, David Faure, \
Eike Hein, and Martin Klapetek.

Changes
-------

Submitted with commit c834ba2196ffbeec5277a224e7a03a5a1f4798ea by Sune Vuorela to \
branch master.

Repository: kiconthemes

Description
-------

According to table 2 in the icon theme spec, the Context per directory key is \
optional, and the Type key defaults to Threshold if not specified. Let's make the \
code do the same.

Diffs
-----

  autotests/breeze.theme 8aef88d 
  autotests/kiconloader_unittest.cpp d1a52fc 
  src/kicontheme.cpp 4f0e522 

Diff: https://git.reviewboard.kde.org/r/124105/diff/

Testing
-------

Thanks,

Sune Vuorela

--===============0284038314309702895==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124105/">https://git.reviewboard.kde.org/r/124105/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Aleix Pol Gonzalez, Christoph Feck, David \
Faure, Eike Hein, and Martin Klapetek.</div> <div>By Sune Vuorela.</div>

<p style="color: grey;"><i>Updated Aug. 16, 2015, 1:14 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit c834ba2196ffbeec5277a224e7a03a5a1f4798ea by Sune \
Vuorela to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">According to table 2 in the icon theme spec, the \
Context per directory key is optional, and the Type key defaults to Threshold if not \
specified. Let's make the code do the same.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/breeze.theme <span style="color: grey">(8aef88d)</span></li>

 <li>autotests/kiconloader_unittest.cpp <span style="color: \
grey">(d1a52fc)</span></li>

 <li>src/kicontheme.cpp <span style="color: grey">(4f0e522)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124105/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0284038314309702895==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 