[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 124596: KBookmarkManager: revert the port from KDirWatch to QFileSystemWatcher.
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2015-08-03 9:50:46
Message-ID: 20150803095046.11735.69652 () mimi ! kde ! org
[Download RAW message or body]
--===============0619316530300074086==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124596/#review83366
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On Aug. 3, 2015, 9:11 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124596/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 9:11 a.m.)
>
>
> Review request for KDE Frameworks and Kevin Ottens.
>
>
> Repository: kbookmarks
>
>
> Description
> -------
>
> QFileSystemWatcher is not able to watch a file that doesn't exist yet,
> it just says
> QInotifyFileSystemWatcherEngine::addPaths: inotify_add_watch failed: No such file \
> or directory and that's the end of it.
>
> We ported to QFileSystemWatcher to reduce deps, but in the end we kept
> KDirWatch, in KCoreAddons.
>
>
> Diffs
> -----
>
> src/kbookmarkmanager.cpp ad6af1ca0c87fe41fd4800ebf5d2924d3bd186fd
> autotests/kbookmarktest.cpp 9a32c2a9e4e1c21ef5c6475f31ed1a67e0e627b4
> autotests/kbookmarktest.h 2127ce89dde030beed2b680af9a0bc452962f4c8
>
> Diff: https://git.reviewboard.kde.org/r/124596/diff/
>
>
> Testing
> -------
>
> unittest added
>
>
> Thanks,
>
> David Faure
>
>
--===============0619316530300074086==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124596/">https://git.reviewboard.kde.org/r/124596/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Kevin Ottens</p>
<br />
<p>On August 3rd, 2015, 9:11 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2015, 9:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kbookmarks
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QFileSystemWatcher is not able to watch a file that doesn't exist \
yet, it just says
QInotifyFileSystemWatcherEngine::addPaths: inotify_add_watch failed: No such file or \
directory and that's the end of it.
We ported to QFileSystemWatcher to reduce deps, but in the end we kept
KDirWatch, in KCoreAddons.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">unittest added</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kbookmarkmanager.cpp <span style="color: \
grey">(ad6af1ca0c87fe41fd4800ebf5d2924d3bd186fd)</span></li>
<li>autotests/kbookmarktest.cpp <span style="color: \
grey">(9a32c2a9e4e1c21ef5c6475f31ed1a67e0e627b4)</span></li>
<li>autotests/kbookmarktest.h <span style="color: \
grey">(2127ce89dde030beed2b680af9a0bc452962f4c8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124596/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0619316530300074086==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic