[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing
From: "Sune Vuorela" <kde () pusling ! com>
Date: 2015-07-15 5:54:53
Message-ID: 20150715055453.27368.96012 () mimi ! kde ! org
[Download RAW message or body]
--===============2037792356105733306==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/#review82521
-----------------------------------------------------------
src/kextracolumnsproxymodel.h (line 39)
<https://git.reviewboard.kde.org/r/124331/#comment56929>
Are there any of these "not supported" things we might want to support in the \
future? Can we implement e.g. adding/removing columns at runtime and still keep the \
abi/api ? I guess for removing columns, one could just add a QSFPM on top and filter \
out the column.
- Sune Vuorela
On July 14, 2015, 10:42 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124331/
> -----------------------------------------------------------
>
> (Updated July 14, 2015, 10:42 a.m.)
>
>
> Review request for KDE Frameworks, Jesper Pedersen and Stephen Kelly.
>
>
> Repository: kitemmodels
>
>
> Description
> -------
>
> REVIEW: 124331
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt f98e87d49b965998f31c5ede1fefb03b159a150f
> autotests/kextracolumnsproxymodeltest.cpp PRE-CREATION
> autotests/test_model_helpers.h a44db8a9cb985f69b52be96f0ffe389ebd903d6f
> src/CMakeLists.txt 82d776f1fcc2f7b15e74f0ed47702ed570ce9892
> src/kextracolumnsproxymodel.h PRE-CREATION
> src/kextracolumnsproxymodel.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124331/diff/
>
>
> Testing
> -------
>
> Wrote autotests (as extensive as possible); used this in one real project, AFAIK \
> Jesper (blackie) did as well.
>
> Thanks,
>
> David Faure
>
>
--===============2037792356105733306==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124331/">https://git.reviewboard.kde.org/r/124331/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124331/diff/3/?file=385294#file385294line39" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kextracolumnsproxymodel.h</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">39</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> *</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Are \
there any of these "not supported" things we might want to support in the future? Can \
we implement e.g. adding/removing columns at runtime and still keep the abi/api ? I \
guess for removing columns, one could just add a QSFPM on top and filter out the \
column.</p></pre> </div>
</div>
<br />
<p>- Sune Vuorela</p>
<br />
<p>On July 14th, 2015, 10:42 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Jesper Pedersen and Stephen Kelly.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated July 14, 2015, 10:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kitemmodels
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">REVIEW: 124331</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Wrote autotests (as extensive as possible); used this \
in one real project, AFAIK Jesper (blackie) did as well.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: \
grey">(f98e87d49b965998f31c5ede1fefb03b159a150f)</span></li>
<li>autotests/kextracolumnsproxymodeltest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/test_model_helpers.h <span style="color: \
grey">(a44db8a9cb985f69b52be96f0ffe389ebd903d6f)</span></li>
<li>src/CMakeLists.txt <span style="color: \
grey">(82d776f1fcc2f7b15e74f0ed47702ed570ce9892)</span></li>
<li>src/kextracolumnsproxymodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/kextracolumnsproxymodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124331/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2037792356105733306==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic