'Re: Review Request 121446: Ignore child mtp devices'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 121446: Ignore child mtp devices
From:       Àlex_Fiestas <afiestas () kde ! org>
Date:       2015-07-11 20:38:59
Message-ID: 20150711203859.16549.2099 () mimi ! kde ! org
[Download RAW message or body]

--===============6068926673472085271==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121446/
-----------------------------------------------------------

(Updated jul. 11, 2015, 8:38 p.m.)

Status
------

This change has been discarded.

Review request for KDE Frameworks and Solid.

Repository: solid

Description
-------

When an mtp device has child usb devices (for example when you plug an android phone \
with debugging), these childs usbs are mark as MTP but we can't really access them.

According to the udev rules installed by libmtp, an alias devlink is added to the \
actual device, so this patch adds a filter for that.

Diffs
-----

  src/solid/devices/backends/udev/udevmanager.cpp 39137ce 

Diff: https://git.reviewboard.kde.org/r/121446/diff/

Testing
-------

Tested with 3 different devices, 2 of them android with and withtout debug and it \
worked fine (plasma shows only 1 working mtp device instead of 3)

Thanks,

Àlex Fiestas

--===============6068926673472085271==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121446/">https://git.reviewboard.kde.org/r/121446/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Solid.</div>
<div>By Àlex Fiestas.</div>

<p style="color: grey;"><i>Updated jul. 11, 2015, 8:38 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When an mtp device has child usb devices (for example \
when you plug an android phone with debugging), these childs usbs are mark as MTP but \
we can't really access them.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">According to the udev rules installed \
by libmtp, an alias devlink is added to the actual device, so this patch adds a \
filter for that.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with 3 different devices, 2 of them android \
with and withtout debug and it worked fine (plasma shows only 1 working mtp device \
instead of 3)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/solid/devices/backends/udev/udevmanager.cpp <span style="color: \
grey">(39137ce)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121446/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6068926673472085271==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 