'Re: Review Request 123946: Add api to disable plot grid lines'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 123946: Add api to disable plot grid lines
From:       "Mark Gaiser" <markg85 () gmail ! com>
Date:       2015-05-30 23:31:00
Message-ID: 20150530233100.31615.37347 () mimi ! kde ! org
[Download RAW message or body]

--===============3685723513072051641==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123946/#review80988
-----------------------------------------------------------

+1 for the api addition.

However, the naming of the api addition seems wrong to me. It's called \
"drawHorizontalGrid" now. That's just wrong. A grid isn't horizontal or vertical, \
it's a grid (it contains both horizontal and vertical lines). A better naming would \
probably be: drawHorizontalLines

or:
drawHorizontalGridLines

- Mark Gaiser

On mei 30, 2015, 6:54 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123946/
> -----------------------------------------------------------
> 
> (Updated mei 30, 2015, 6:54 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Thomas Pfeiffer.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This is from feedback from the VDG: for the system monitor widget would be better \
> to not have the horizontal grid lines for the plots as they don't add much \
> information in this case and clutter the scene a bit. the system monitor applets \
> would make use of this. 
> to maintain compatibility still draw the lines, but add api to disable them (since \
> there already was api for the grid, it shouldn't be broken) 
> 
> Diffs
> -----
> 
> src/qmlcontrols/kquickcontrolsaddons/plotter.h a564761 
> src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 9a939c3 
> 
> Diff: https://git.reviewboard.kde.org/r/123946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 

--===============3685723513072051641==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123946/">https://git.reviewboard.kde.org/r/123946/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 \
for the api addition.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">However, the naming of the api addition \
seems wrong to me. It's called "drawHorizontalGrid" now. That's just wrong. A grid \
isn't horizontal or vertical, it's a grid (it contains both horizontal and vertical \
lines). A better naming would probably be:
drawHorizontalLines</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">or: drawHorizontalGridLines</p></pre>
 <br />

<p>- Mark Gaiser</p>

<br />
<p>On mei 30th, 2015, 6:54 p.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma and Thomas Pfeiffer.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated mei 30, 2015, 6:54 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is from feedback from the VDG: for the system \
monitor widget would be better to not have the horizontal grid lines for the plots as \
they don't add much information in this case and clutter the scene a bit. the system \
monitor applets would make use of this.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">to maintain \
compatibility still draw the lines, but add api to disable them (since there already \
was api for the grid, it shouldn't be broken)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qmlcontrols/kquickcontrolsaddons/plotter.h <span style="color: \
grey">(a564761)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/plotter.cpp <span style="color: \
grey">(9a939c3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123946/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3685723513072051641==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 