[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs
From: "Milian Wolff" <mail () milianw ! de>
Date: 2015-05-21 8:01:41
Message-ID: 20150521080141.11005.15991 () mimi ! kde ! org
[Download RAW message or body]
--===============5146381255178004585==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123867/#review80680
-----------------------------------------------------------
Ship it!
Ship It!
src/klocalizedstring.cpp (line 23)
<https://git.reviewboard.kde.org/r/123867/#comment55313>
shouldn't this be
#include <cmath>
- Milian Wolff
On May 21, 2015, 5:50 a.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123867/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 5:50 a.m.)
>
>
> Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett Clark.
>
>
> Repository: ki18n
>
>
> Description
> -------
>
> https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/1/console
>
> Follow up to,
>
> commit 8d392e523e4556f9e434f3e02890fcacfcb492e4
> Author: Milian Wolff <mail@milianw.de>
> Date: Mon May 18 10:52:29 2015 +0200
>
> Fix compiler warning about potential truncation.
>
> klocalizedstring.cpp:1126:46: warning: absolute value function 'abs'
> given an argument of type 'long' but has parameter of type 'int'
> which may cause truncation of value
>
> kls.d->number = static_cast<pluraln>(abs(a));
> ^
> klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead
>
>
> Diffs
> -----
>
> src/klocalizedstring.cpp 910f44d
>
> Diff: https://git.reviewboard.kde.org/r/123867/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bhushan Shah
>
>
--===============5146381255178004585==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123867/">https://git.reviewboard.kde.org/r/123867/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123867/diff/1/?file=370328#file370328line23" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/klocalizedstring.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">23</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <cstdlib></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">shouldn't this be</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: \
#BC7A00">#include <cmath></span> </pre></div>
</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On May 21st, 2015, 5:50 a.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett \
Clark.</div> <div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated May 21, 2015, 5:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/1/console
Follow up to,
commit 8d392e523e4556f9e434f3e02890fcacfcb492e4
Author: Milian Wolff <mail@milianw.de>
Date: Mon May 18 10:52:29 2015 +0200
Fix compiler warning about potential truncation.
klocalizedstring.cpp:1126:46: warning: absolute value function 'abs'
given an argument of type 'long' but has parameter of type 'int'
which may cause truncation of value
kls.d->number = static_cast<pluraln>(abs(a));
^
klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/klocalizedstring.cpp <span style="color: grey">(910f44d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123867/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5146381255178004585==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic