'Re: Review Request 123439: Coding Style for karchive_p.h kbzip2filter.h'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 123439: Coding Style for karchive_p.h kbzip2filter.h
From:       "Guy Maurel" <guy-kde () maurel ! de>
Date:       2015-05-15 16:05:15
Message-ID: 20150515160515.8613.43783 () mimi ! kde ! org
[Download RAW message or body]

--===============6497684150579370393==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123439/
-----------------------------------------------------------

(Updated May 15, 2015, 4:05 p.m.)

Status
------

This change has been marked as submitted.

Review request for Akonadi, KDE Frameworks, Mario Bensi, and David Faure.

Changes
-------

Submitted with commit 5b895eba62517c69020736276dd35c4ac96bb957 by Guy Maurel to \
branch master.

Repository: karchive

Description
-------

We use for karchive the same rules as for kdepim:
  http://techbase.kde.org/Policies/Kdepim_Coding_Style

If wished, we could have extra policy for karchive.
(Let me know)

Diffs
-----

  src/karchive_p.h 26a98659b860b379f28ee9442df7a0dd5209f89d 
  src/kbzip2filter.h 767dabe 
  src/kcompressiondevice.h 9e0c2c0f04ac9f4401e9f1a8c2a0b71f3ef327ed 
  src/kfilterbase.h 9cbaf950ce42878d426b358582c3b62a1ded9aaf 
  src/klimitediodevice_p.h 51929aa 
  src/kxzfilter.h 8747a29 
  src/kzip.h 11ca330 

Diff: https://git.reviewboard.kde.org/r/123439/diff/

Testing
-------

Could anybody take care of this review after 30 days? Thanks.

Thanks,

Guy Maurel

--===============6497684150579370393==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123439/">https://git.reviewboard.kde.org/r/123439/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Akonadi, KDE Frameworks, Mario Bensi, and David Faure.</div>
<div>By Guy Maurel.</div>

<p style="color: grey;"><i>Updated May 15, 2015, 4:05 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 5b895eba62517c69020736276dd35c4ac96bb957 by Guy \
Maurel to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We use for karchive the same rules as for kdepim:  \
http://techbase.kde.org/Policies/Kdepim_Coding_Style

If wished, we could have extra policy for karchive.
(Let me know)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Could anybody take care of this review after 30 days? \
Thanks.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/karchive_p.h <span style="color: \
grey">(26a98659b860b379f28ee9442df7a0dd5209f89d)</span></li>

 <li>src/kbzip2filter.h <span style="color: grey">(767dabe)</span></li>

 <li>src/kcompressiondevice.h <span style="color: \
grey">(9e0c2c0f04ac9f4401e9f1a8c2a0b71f3ef327ed)</span></li>

 <li>src/kfilterbase.h <span style="color: \
grey">(9cbaf950ce42878d426b358582c3b62a1ded9aaf)</span></li>

 <li>src/klimitediodevice_p.h <span style="color: grey">(51929aa)</span></li>

 <li>src/kxzfilter.h <span style="color: grey">(8747a29)</span></li>

 <li>src/kzip.h <span style="color: grey">(11ca330)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123439/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6497684150579370393==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 