[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 123731: Cleanup handling of notifications closing
From: Jan_Kundrát <jkt () kde ! org>
Date: 2015-05-12 22:54:46
Message-ID: 20150512225446.8613.73417 () mimi ! kde ! org
[Download RAW message or body]
--===============4872102030735863697==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123731/#review80265
-----------------------------------------------------------
Is it OK to have a non-null main object whose d-ptr is nullptr already? If not, can \
you fix the cause of that?
src/notifybypopup.cpp (line 491)
<https://git.reviewboard.kde.org/r/123731/#comment55062>
Is there an enum for this? Using that instead of a comment which explains what a \
magic value is about sounds much better.
- Jan Kundrát
On May 12, 2015, 11:59 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123731/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 11:59 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> While investigating the cause of crash of \
> https://bugs.kde.org/show_bug.cgi?id=342752 I've come across some loose ends in how \
> KNotifications is handling closing of notifications.
> As for the crash itself, I never managed to reproduce even with special written \
> test cases, but what happens (or seem to) is this:
> * KNotification object gets deleted
> * The destructor calls close() on all plugins
> * The NotifyByPopup plugin does async dbus call to close the notification and \
> returns
> * KNotification's dpointer is deleted
> * The DBus reply returns, calling NotifyByPopup::finished()
> * Now for some reason the KNotification object is still not null but its dpointer \
> is gone, so the check "if (!notification || \
> d->notifications.contains(notification->id()))" crashes on the notification->id() \
> call
> So I've made it simply return -1 when dpointer is null, which should ideally \
> prevent the crashes
>
> Diffs
> -----
>
> src/knotification.cpp 01962b3
> src/knotificationmanager.cpp 0d9b3b0
> src/knotificationmanager_p.h f8e7df8
> src/notifybypopup.cpp 2f84ab0
>
> Diff: https://git.reviewboard.kde.org/r/123731/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============4872102030735863697==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123731/">https://git.reviewboard.kde.org/r/123731/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it \
OK to have a non-null main object whose d-ptr is nullptr already? If not, can you fix \
the cause of that?</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123731/diff/1/?file=368324#file368324line492" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/notifybypopup.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
NotifyByPopup::onGalagoNotificationClosed(uint dbus_id, uint reason)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">492</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">n</span><span class="o">-></span><span class="n">close</span><span \
class="p">();</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">491</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">reason</span> <span class="o">==</span> <span \
class="mi">2</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is \
there an enum for this? Using that instead of a comment which explains what a magic \
value is about sounds much better.</p></pre> </div>
</div>
<br />
<p>- Jan Kundrát</p>
<br />
<p>On May 12th, 2015, 11:59 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 12, 2015, 11:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While investigating the cause of crash of \
https://bugs.kde.org/show_bug.cgi?id=342752 I've come across some loose ends in \
how KNotifications is handling closing of notifications.
As for the crash itself, I never managed to reproduce even with special written test \
cases, but what happens (or seem to) is this:
* KNotification object gets deleted
* The destructor calls close() on all plugins
* The NotifyByPopup plugin does async dbus call to close the notification and \
returns
* KNotification's dpointer is deleted
* The DBus reply returns, calling NotifyByPopup::finished()
* Now for some reason the KNotification object is still not null but its dpointer is \
gone, so the check "if (!notification || \
d->notifications.contains(notification->id()))" crashes on the \
notification->id() call
So I've made it simply return -1 when dpointer is null, which should ideally \
prevent the crashes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/knotification.cpp <span style="color: grey">(01962b3)</span></li>
<li>src/knotificationmanager.cpp <span style="color: grey">(0d9b3b0)</span></li>
<li>src/knotificationmanager_p.h <span style="color: grey">(f8e7df8)</span></li>
<li>src/notifybypopup.cpp <span style="color: grey">(2f84ab0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123731/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4872102030735863697==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic