[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-05-03 22:00:30
Message-ID: 20150503220030.1888.22092 () mimi ! kde ! org
[Download RAW message or body]
--===============8209295973340661860==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On May 3, 2015, 2:34 p.m., Albert Astals Cid wrote:
> > I'm confused, the title say "Remove KAboutData" and then goes and changes i18n \
> > while breaking it?
> > I mean i18n handling is relatively easy, and we have pretty good documentation at \
> > https://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems on \
> > what to do, so i'm kind of sad of "this is not my issue, i'll just change stuff \
> > enough so that it 'works' for me and for someone else to fix it propertly" \
> > mindset.
> > So let me ask you, what are you missing from the above link that makes it hard \
> > for you to fix the i18n handling?
No, it's a "we're a team" mindset. And maybe it's also a "let's help fulfil one of \
the points why frameworks were made into frameworks and help out other projects \
wanting to use it because we know our own stuff better" mindset. I kind of don't \
really expect them to know every single detail of how KI18n works or what techbase \
is.
Nevertheless and more to the point, "add the ecm loading of the existing \
kglobalaccel5_qt qm to the daemon" is something that is not in that wiki at all.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122680/#review79794
-----------------------------------------------------------
On May 1, 2015, 9:18 p.m., Jerome Leclanche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122680/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 9:18 p.m.)
>
>
> Review request for KDE Frameworks, Localization and Translation (l10n), Albert \
> Astals Cid, Martin Gräßlin, and Martin Klapetek.
>
> Repository: kglobalaccel
>
>
> Description
> -------
>
> Remove the runtime's KAboutData
>
> The about data was unexposed, but created a dependency on KCoreAddons (for
> KAboutData) and in turn on KI18n for the translations of the aboutData.
>
> This removes both dependencies as well as the string extraction scripts.
>
> --
>
> Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would
> like to, however it currently has too many dependencies. See
> https://github.com/lxde/lxqt/issues/507 for related discussion.
> I'm unsure myself if the about data is actually exposed somewhere I completely
> missed, but it doesn't look that way.
>
>
> Diffs
> -----
>
> CMakeLists.txt 68ad795
> src/runtime/CMakeLists.txt e639fa5
> src/runtime/globalshortcutsregistry.cpp 3e4d720
> src/runtime/kglobalacceld.cpp 4e7cb9d
> src/runtime/main.cpp fdf4d62
>
> Diff: https://git.reviewboard.kde.org/r/122680/diff/
>
>
> Testing
> -------
>
> Compiles and runs. No further testing done.
>
>
> Thanks,
>
> Jerome Leclanche
>
>
--===============8209295973340661860==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122680/">https://git.reviewboard.kde.org/r/122680/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 3rd, 2015, 2:34 p.m. CEST, <b>Albert Astals \
Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm confused, the title say "Remove KAboutData" and \
then goes and changes i18n while breaking it?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
mean i18n handling is relatively easy, and we have pretty good documentation at \
https://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems on \
what to do, so i'm kind of sad of "this is not my issue, i'll just change stuff \
enough so that it 'works' for me and for someone else to fix it propertly" \
mindset.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So let me ask you, what are you missing from the above \
link that makes it hard for you to fix the i18n handling?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, \
it's a "we're a team" mindset. And maybe it's also a "let's help fulfil one of the \
points why frameworks were made into frameworks and help out other projects wanting \
to use it because we know our own stuff better" mindset. I kind of don't really \
expect them to know every single detail of how KI18n works or what techbase is.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Nevertheless and more to the point, "add the ecm \
loading of the existing kglobalaccel5_qt qm to the daemon" is something that is not \
in that wiki at all.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On May 1st, 2015, 9:18 p.m. CEST, Jerome Leclanche wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Localization and Translation (l10n), Albert \
Astals Cid, Martin Gräßlin, and Martin Klapetek.</div> <div>By Jerome \
Leclanche.</div>
<p style="color: grey;"><i>Updated May 1, 2015, 9:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove the runtime's KAboutData
The about data was unexposed, but created a dependency on KCoreAddons (for
KAboutData) and in turn on KI18n for the translations of the aboutData.
This removes both dependencies as well as the string extraction scripts.
--
Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would
like to, however it currently has too many dependencies. See
https://github.com/lxde/lxqt/issues/507 for related discussion.
I'm unsure myself if the about data is actually exposed somewhere I completely
missed, but it doesn't look that way.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles and runs. No further testing done.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(68ad795)</span></li>
<li>src/runtime/CMakeLists.txt <span style="color: grey">(e639fa5)</span></li>
<li>src/runtime/globalshortcutsregistry.cpp <span style="color: \
grey">(3e4d720)</span></li>
<li>src/runtime/kglobalacceld.cpp <span style="color: grey">(4e7cb9d)</span></li>
<li>src/runtime/main.cpp <span style="color: grey">(fdf4d62)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122680/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8209295973340661860==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic