'Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
From:       "Ashish Bansal" <bansal.ashish096 () gmail ! com>
Date:       2015-05-02 19:26:28
Message-ID: 20150502192628.32057.18944 () mimi ! kde ! org
[Download RAW message or body]

--===============6225099866231026694==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
-----------------------------------------------------------

(Updated May 2, 2015, 7:26 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK.

Changes
-------

Submitted with commit c806f88e4ea65330719fa1721cdf15ea5cbddb5a by Ashish Bansal to \
branch master.

Bugs: 341773
    https://bugs.kde.org/show_bug.cgi?id=341773

Repository: kio

Description
-------

For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong \
name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz

Diffs
-----

  autotests/globaltest.cpp ff8725d 
  src/core/global.cpp f18ac10 

Diff: https://git.reviewboard.kde.org/r/123224/diff/

Testing
-------

Works fine!

Thanks,

Ashish Bansal

--===============6225099866231026694==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123224/">https://git.reviewboard.kde.org/r/123224/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun \
AK.</div> <div>By Ashish Bansal.</div>

<p style="color: grey;"><i>Updated May 2, 2015, 7:26 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit c806f88e4ea65330719fa1721cdf15ea5cbddb5a by Ashish \
Bansal to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=341773">341773</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For filenames like filename-1.6.tar.gz, \
KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected \
name: filename-1.6 (1).tar.gz</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works fine!</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/globaltest.cpp <span style="color: grey">(ff8725d)</span></li>

 <li>src/core/global.cpp <span style="color: grey">(f18ac10)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123224/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6225099866231026694==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 