[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 123540: Don't trigger updates when no actual updates
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-04-28 9:02:06
Message-ID: 20150428090206.14758.11924 () mimi ! kde ! org
[Download RAW message or body]
--===============8959425234661544274==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123540/#review79619
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On April 28, 2015, 8:33 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123540/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 8:33 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Bugs: 345973
> https://bugs.kde.org/show_bug.cgi?id=345973
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> This patch checks if the properties being set are actually changed before emitting \
> the update signal, which would cause a re-emit of the notification.
> Furthermore, NotifyByPopup now no longer changes the KNotification object when the \
> server does not support certain capabilities but only does local checking and \
> modifications.
> This fixes KNotification use with Ubuntu's NotifyOSD.
>
>
> Diffs
> -----
>
> src/knotification.cpp afac82f
> src/notifybypopup.cpp 316ff2b
>
> Diff: https://git.reviewboard.kde.org/r/123540/diff/
>
>
> Testing
> -------
>
> Before this patch there was a continous loop of setting empty actions because the \
> server does not support them -> triggers update -> triggers setting empty actions \
> -> triggers update -> and so on. This made the notification popup look stuck and \
> would block all other notifications from appearing (NotifyOSD supports only one \
> popup at a time).
> Now everything behaves correctly.
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============8959425234661544274==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123540/">https://git.reviewboard.kde.org/r/123540/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Edmundson</p>
<br />
<p>On April 28th, 2015, 8:33 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 28, 2015, 8:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=345973">345973</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch checks if the properties being set are \
actually changed before emitting the update signal, which would cause a re-emit of \
the notification.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Furthermore, NotifyByPopup now no \
longer changes the KNotification object when the server does not support certain \
capabilities but only does local checking and modifications.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
fixes KNotification use with Ubuntu's NotifyOSD.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Before this patch there was a continous loop of \
setting empty actions because the server does not support them -> triggers update \
-> triggers setting empty actions -> triggers update -> and so on. This made \
the notification popup look stuck and would block all other notifications from \
appearing (NotifyOSD supports only one popup at a time).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now \
everything behaves correctly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/knotification.cpp <span style="color: grey">(afac82f)</span></li>
<li>src/notifybypopup.cpp <span style="color: grey">(316ff2b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123540/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8959425234661544274==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic