'Re: Review Request 122987: Allow user to specify path to myspell dictionary files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 122987: Allow user to specify path to myspell dictionary files
From:       "Eugene Shalygin" <eugene.shalygin () gmail ! com>
Date:       2015-04-07 12:20:17
Message-ID: 20150407122017.31692.409 () mimi ! kde ! org
[Download RAW message or body]

--===============8732855074862153020==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
-----------------------------------------------------------

(Updated Квітень 7, 2015, 2:20 після полудня)

Review request for KDE Frameworks and kdelibs.

Repository: sonnet

Description
-------

Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/,  which is hardcoded in \
the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user define \
this path.

Diffs (updated)
-----

  src/plugins/hunspell/CMakeLists.txt 098fb49 
  src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
  src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
  src/plugins/hunspell/hunspelldict.cpp 621113d 

Diff: https://git.reviewboard.kde.org/r/122987/diff/

Testing
-------

hunspell plugin began to work on Gentoo

Thanks,

Eugene Shalygin

--===============8732855074862153020==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122987/">https://git.reviewboard.kde.org/r/122987/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Eugene Shalygin.</div>

<p style="color: grey;"><i>Updated Квітень 7, 2015, 2:20 після полудня</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Not on all systems myspell dictionaries are \
located in /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. For instance, \
on Gentoo it is /usr/share/myspell/. So let the user define this path.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">hunspell plugin began to work on \
Gentoo</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plugins/hunspell/CMakeLists.txt <span style="color: grey">(098fb49)</span></li>

 <li>src/plugins/hunspell/config-hunspellplugin.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/plugins/hunspell/hunspellclient.cpp <span style="color: grey">(9e3aa67)</span></li>

 <li>src/plugins/hunspell/hunspelldict.cpp <span style="color: grey">(621113d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122987/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8732855074862153020==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 